Make access unsafe

Author: SylvainCorlay

include/pybind11/numpy.h

@@ -510,15 +510,17 @@ class array : public buffer {
     }
 
     template<typename... Ix> size_t byte_offset(Ix... index) const {
-        check_dimensions(index...);
         return byte_offset_unsafe(index...);
     }
 
+    PYBIND11_DEPRECATED("Use array<T>::byte_offset() instead")
     template<size_t dim = 0, typename... Ix> size_t byte_offset_unsafe(size_t i, Ix... index) const {
         return i * strides()[dim] + byte_offset_unsafe<dim + 1>(index...);
     }
 
-    template<size_t dim = 0> size_t byte_offset_unsafe() const { return 0; }
+    template<size_t dim = 0> size_t byte_offset_unsafe() const {
+        return 0;
+    }
 
     void check_writeable() const {
         if (!writeable())
@@ -537,21 +539,6 @@ class array : public buffer {
         return strides;
     }
 
-    template<typename... Ix> void check_dimensions(Ix... index) const {
-        check_dimensions_impl(size_t(0), shape(), size_t(index)...);
-    }
-
-    void check_dimensions_impl(size_t, const size_t*) const { }
-
-    template<typename... Ix> void check_dimensions_impl(size_t axis, const size_t* shape, size_t i, Ix... index) const {
-        if (i >= *shape) {
-            throw index_error(std::string("index ") + std::to_string(i) +
-                              " is out of bounds for axis " + std::to_string(axis) +
-                              " with size " + std::to_string(*shape));
-        }
-        check_dimensions_impl(axis + 1, shape + 1, index...);
-    }
-
     /// Create array from any object -- always returns a new reference
     static PyObject *raw_array(PyObject *ptr, int ExtraFlags = 0) {
         if (ptr == nullptr)