Skip to content

ci: Travis Job for Python 3.8 on Linux does not actually run Python 3.8? #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EricCousineau-TRI opened this issue Apr 9, 2020 · 8 comments

Comments

@EricCousineau-TRI
Copy link
Collaborator

Issue description

If you look at any job Python 3.8, c++17, gcc 7 (w/o numpy/scipy) in Travis CI builds, they don't seem to actually be using Python 3.8. (Not sure if this is due to a patch I submitted...)

Came across this is in our fork, which effectively uses the same CI scripts here.

Reproducible example code

See this build:

https://travis-ci.org/github/pybind/pybind11/jobs/640390164#L467

-- Found PythonInterp: /opt/pyenv/shims/python3 (found version "3.6.7")

@carlsonmark
Copy link

Do you think that changing PY_CMD=python3 to PY_CMD=python3.8 would be sufficient to fix that? Or is there more todo?

@EricCousineau-TRI
Copy link
Collaborator Author

Yup, I think that would be it!

Testing it out in my fork, can PR the patch if I can confirm it works:
RobotLocomotion#40

(I may also disable one of the PyPy jobs, as that seems to be freezing on a download?)

@carlsonmark
Copy link

OK. I think if that doesn't work, then maybe some clever use of update-alternatives may help. I'm not really familiar with any of that though. I'm just starting to look into travis-ci myself, here.

Good luck!

@carlsonmark
Copy link

Looks like you will need to add this package too:

          - python3.8-distutils

Which allows python3.8 -m pip to work on xenial.

@carlsonmark
Copy link

carlsonmark commented Apr 9, 2020

My mistake, I had installed python3.8 from snap a while ago and uninstalled it, so my environment is not clean.

This may be the way to install pip in python3.8 (on xenial) using deadsnakes: deadsnakes/issues#95

curl https://bootstrap.pypa.io/get-pip.py | python3.8

But you might want to read that page first in case you think it may be a bad idea.

@EricCousineau-TRI
Copy link
Collaborator Author

Hm... Lemme try out python3 -m ensurepip, as that tends to work when build CPython from source. Thanks!

@chaitan94
Copy link
Contributor

Possibly related: #1090

@henryiii
Copy link
Collaborator

This has all been wiped out and replaced by GHA, and those do run the correct versions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants