-
Notifications
You must be signed in to change notification settings - Fork 2.2k
CMake improvement: support windows python with msys & mingw #2312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So this looks reasonable, but someone with more experience with msys/mingw needs to give his blessing. |
That's not me, but I don't know if there is a regular contributor that has more experience? There's talks to ditch all this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this one question gets resolved, I don't see how it could hurt non-mingw/msys builds, so as far as I'm concerned, it could be merged, if it solves an issue.
I don't think we will be able to ditch it, at least for a while, but there will (hopefully) be a much better way to do it soon. But agree that we should still get fixes like this in! |
Ow, then I got slightly too excited. Even better to get this in then. |
- look for windows python lib when using mingw & msys - if not found, then look for system python lib as before
0915198
to
c5fb605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too. :)
OK, and it's green, so let's merge it then? :-) Thanks, @lkeegan! |
thanks! |
Change to
FindPythonLibsNew.cmake
behaviour:Previous behaviour was to skip the first step when using msys & mingw, so windows python libs are not found (see example travis job):
i.e. doesn't find the python library
New behaviour with this PR (see example travis job):