Skip to content

Add an update prompt when using the CLI #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viicos opened this issue Apr 1, 2025 · 2 comments
Open

Add an update prompt when using the CLI #977

Viicos opened this issue Apr 1, 2025 · 2 comments
Assignees
Labels

Comments

@Viicos
Copy link
Member

Viicos commented Apr 1, 2025

Description

As per our EU region checklist, a follow up feature was to implement a version check when using the CLI (at least for logfire auth, might apply to other commands), similar to what pip does.

@Viicos Viicos self-assigned this Apr 2, 2025
@Viicos Viicos added the P3 Less than P2. label Apr 2, 2025
@Viicos
Copy link
Member Author

Viicos commented Apr 2, 2025

Unfortunately the PyPI API doesn't support querying only for the latest version (see pypi/warehouse#4663). The current payload at https://pypi.org/pypi/logfire/json takes 166.74 kB, which could slown down the CLI on slow connections. Alternatively, we could only check for new versions every x days/weeks (pip does it every week), but this requires some extra work to cache the last check timestamp.

@alexmojaki
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants