Skip to content

Commit 2957fdf

Browse files
Remove lock kwarg (#5912)
Co-authored-by: Illviljan <[email protected]>
1 parent 89e13b0 commit 2957fdf

File tree

3 files changed

+2
-18
lines changed

3 files changed

+2
-18
lines changed

doc/whats-new.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ Breaking changes
3131

3232
Deprecations
3333
~~~~~~~~~~~~
34+
- Removed the lock kwarg from the zarr and pydap backends, completing the deprecation cycle started in :issue:`5256`.
35+
By `Tom Nicholas <https://github.com/TomNicholas>`_.
3436

3537

3638
Bug fixes

xarray/backends/pydap_.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import warnings
2-
31
import numpy as np
42

53
from ..core import indexing
@@ -126,15 +124,7 @@ def open_dataset(
126124
use_cftime=None,
127125
decode_timedelta=None,
128126
session=None,
129-
lock=None,
130127
):
131-
# TODO remove after v0.19
132-
if lock is not None:
133-
warnings.warn(
134-
"The kwarg 'lock' has been deprecated for this backend, and is now "
135-
"ignored. In the future passing lock will raise an error.",
136-
DeprecationWarning,
137-
)
138128

139129
store = PydapDataStore.open(
140130
filename_or_obj,

xarray/backends/zarr.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -810,15 +810,7 @@ def open_dataset(
810810
chunk_store=None,
811811
storage_options=None,
812812
stacklevel=3,
813-
lock=None,
814813
):
815-
# TODO remove after v0.19
816-
if lock is not None:
817-
warnings.warn(
818-
"The kwarg 'lock' has been deprecated for this backend, and is now "
819-
"ignored. In the future passing lock will raise an error.",
820-
DeprecationWarning,
821-
)
822814

823815
filename_or_obj = _normalize_path(filename_or_obj)
824816
store = ZarrStore.open_group(

0 commit comments

Comments
 (0)