Skip to content

Commit 3ddf9c1

Browse files
committed
Removes _close_ds functions
1 parent 9d52ce3 commit 3ddf9c1

File tree

2 files changed

+8
-14
lines changed

2 files changed

+8
-14
lines changed

xarray/backends/h5netcdf_.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@ def _read_attributes(h5netcdf_var):
4646
_extract_h5nc_encoding = functools.partial(_extract_nc4_variable_encoding,
4747
lsd_okay=False, backend='h5netcdf')
4848

49-
def _close_ds(ds):
50-
# netCDF4 only allows closing the root group
51-
ds = find_root(ds)
52-
if not ds._closed:
53-
ds.close()
54-
5549
def _open_h5netcdf_group(filename, mode, group):
5650
import h5netcdf.legacyapi
5751
ds = h5netcdf.legacyapi.Dataset(filename, mode=mode)
@@ -162,5 +156,8 @@ def sync(self):
162156

163157
def close(self):
164158
if self._isopen:
165-
_close_ds(self.ds)
159+
# netCDF4 only allows closing the root group
160+
ds = find_root(self.ds)
161+
if not ds._closed:
162+
ds.close()
166163
self._isopen = False

xarray/backends/netCDF4_.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,6 @@ def _extract_nc4_variable_encoding(variable, raise_on_invalid=False,
177177

178178
return encoding
179179

180-
def _close_ds(ds):
181-
# netCDF4 only allows closing the root group
182-
ds = find_root(ds)
183-
if ds._isopen:
184-
ds.close()
185-
186180

187181
def _open_netcdf4_group(filename, mode, group=None, **kwargs):
188182
import netCDF4 as nc4
@@ -342,5 +336,8 @@ def sync(self):
342336

343337
def close(self):
344338
if self._isopen:
345-
_close_ds(self.ds)
339+
# netCDF4 only allows closing the root group
340+
ds = find_root(self.ds)
341+
if ds._isopen:
342+
ds.close()
346343
self._isopen = False

0 commit comments

Comments
 (0)