Deprecate some positional args

Author: dcherian

xarray/core/dataarray.py

@@ -6681,11 +6681,13 @@ def interp_calendar(
         """
         return interp_calendar(self, target, dim=dim)
 
+    @_deprecate_positional_args("v2024.08.0")
     def groupby(
         self,
         group: (
             Hashable | DataArray | IndexVariable | Mapping[Any, Grouper] | None
         ) = None,
+        *,
         squeeze: bool | None = None,
         restore_coord_dims: bool = False,
         **groupers: Grouper,
@@ -6802,10 +6804,12 @@ def groupby(
             restore_coord_dims=restore_coord_dims,
         )
 
+    @_deprecate_positional_args("v2024.08.0")
     def groupby_bins(
         self,
         group: Hashable | DataArray | IndexVariable,
         bins: ArrayLike,
+        *,
         right: bool = True,
         labels: ArrayLike | Literal[False] | None = None,
         precision: int = 3,
@@ -7226,9 +7230,11 @@ def coarsen(
             coord_func=coord_func,
         )
 
+    @_deprecate_positional_args("v2024.08.0")
     def resample(
         self,
         indexer: Mapping[Hashable, str | Resampler] | None = None,
+        *,
         skipna: bool | None = None,
         closed: SideOptions | None = None,
         label: SideOptions | None = None,

xarray/core/dataset.py

@@ -10255,11 +10255,13 @@ def interp_calendar(
         """
         return interp_calendar(self, target, dim=dim)
 
+    @_deprecate_positional_args("v2024.08.0")
     def groupby(
         self,
         group: (
             Hashable | DataArray | IndexVariable | Mapping[Any, Grouper] | None
         ) = None,
+        *,
         squeeze: bool | None = None,
         restore_coord_dims: bool = False,
         **groupers: Grouper,
@@ -10343,10 +10345,12 @@ def groupby(
             restore_coord_dims=restore_coord_dims,
         )
 
+    @_deprecate_positional_args("v2024.08.0")
     def groupby_bins(
         self,
         group: Hashable | DataArray | IndexVariable,
         bins: ArrayLike,
+        *,
         right: bool = True,
         labels: ArrayLike | None = None,
         precision: int = 3,
@@ -10612,9 +10616,11 @@ def coarsen(
             coord_func=coord_func,
         )
 
+    @_deprecate_positional_args("v2024.08.0")
     def resample(
         self,
         indexer: Mapping[Any, str | Resampler] | None = None,
+        *,
         skipna: bool | None = None,
         closed: SideOptions | None = None,
         label: SideOptions | None = None,