-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
rolling requires pandas >= 0.18 #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We should probably update our minimum required dependencies for the next release, both for pandas and numpy. Pandas 0.15 and numpy 1.7 are pretty old now.
Yes, this is not intended! |
OK. I will send a PR to update the minimum version support. How about numpy? pandas itself does not require newer numpy. |
pandas 0.18 came out in March 2016 (about 18 months ago by the time of our next release). I would be reluctant to require anything newer than NumPy 1.11, which also came out in March 2016. I don't see removing functions from npcompat as particularly good justification on its own. But if there is new functionality that requires a newer NumPy, then that could be a good reason to require something newer (especially if it's hard to backport). For example, if we required NumPy 1.13, then we could make use of |
Yes. Agreed. Though I do not yet understand well about I think to solve this particular issue, we can update supported oldest numpy to 1.11 (or 1.10). |
I'm +1 for requiring NumPy 1.11 and pandas 0.18.
Agreed! |
We need pandas >= 0.18 because dataframe.rolling is supported after 0.18.
But
requirements
in our setup.py says we need pandas >= 0.15.Additionally, I noticed that in travis's CONDA_ENV=py27-min setup, our unit tests run with pandas == 0.20, though it might be intended to run with pandas == 0.15.
By
conda remove scipy
, pandas.0.15 is removed.(Here is the travis log)
then in
python setup.py install
, pandas==0.20.3 is installed.The text was updated successfully, but these errors were encountered: