Skip to content

Pass arguments to dask.compute() #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crusaderky opened this issue Aug 24, 2017 · 5 comments
Closed

Pass arguments to dask.compute() #1523

crusaderky opened this issue Aug 24, 2017 · 5 comments

Comments

@crusaderky
Copy link
Contributor

crusaderky commented Aug 24, 2017

I work with a very large dask-based algorithm in xarray, and I do my optimization by hand before hitting compute(). In other cases, I need using multiple dask schedulers at once (e.g. a multithreaded one for numpy-based work and a multiprocessing one for pure python work).

This change proposal (which I'm happy to do) is about accepting *args, **kwds parameters in all .compute(), .load(), and .persist() xarray methods and pass them verbatim to the underlying dask compute() and persist() functions.

@shoyer
Copy link
Member

shoyer commented Aug 24, 2017

Yes, this sounds like a great idea to me!

@crusaderky crusaderky mentioned this issue Aug 28, 2017
13 tasks
@crusaderky
Copy link
Contributor Author

Working on it now

@jhamman
Copy link
Member

jhamman commented Aug 31, 2017

@crusaderky - did you make any progress here? I also have a feature branch that I started on the plane a few days back...

@crusaderky
Copy link
Contributor Author

@jhamman I finished the implementation I have to write the unit tests this weekend

@crusaderky
Copy link
Contributor Author

@jhamman 's implementation is far more complete than mine, I pass the trophy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants