Skip to content

Use apply_ufunc in xESMF regridding package #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrocklin opened this issue Jan 12, 2018 · 4 comments
Closed

Use apply_ufunc in xESMF regridding package #1822

mrocklin opened this issue Jan 12, 2018 · 4 comments
Labels

Comments

@mrocklin
Copy link
Contributor

I would like to call attention to JiaweiZhuang/xESMF#3 (comment) . It seems like the xESMF package does regridding in a way that at least some XArray users find sensible. It should probably make use of, but does not currently use apply_ufunc, and is not particularly parallelizable (or at least that is my understanding). It could be that some modest development by someone more familiar with XArray could have a large impact by properly using apply_ufunc within that codebase.

I apologize for posting an issue about another package in this issue tracker. Feel free to close.

cc @JiaweiZhuang

@JiaweiZhuang
Copy link

Thanks for bringing this up... I've made more experiments and realized that Numba is actually faster than scipy.sparse, and also shows excellent parallel efficiency. See this notebook for all details. Thus I consider switch to Numba and add parallel support in the next version. It should fit better than xr.apply_ufunc in this case. Let's discuss in the original thread if you have further suggestions.

@mrocklin
Copy link
Contributor Author

I would think that the use of numba for sparse matrix multiply would be orthogonal to the choice of parallelizing with apply_ufunc. I think that one can likely do both.

@JiaweiZhuang
Copy link

I agree that they can be both implemented, and dask is useful for out-of-core. If anyone would like to contribute, please see JiaweiZhuang/xESMF#3 (comment) for my preliminary experiments with xr.apply_ufunc.

@stale
Copy link

stale bot commented Dec 15, 2019

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

@stale stale bot added the stale label Dec 15, 2019
@stale stale bot closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants