Skip to content

⚠️ Nightly upstream-dev CI failed ⚠️ #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions bot opened this issue Oct 18, 2021 · 2 comments · Fixed by #5899
Closed

⚠️ Nightly upstream-dev CI failed ⚠️ #5872

github-actions bot opened this issue Oct 18, 2021 · 2 comments · Fixed by #5899
Labels
CI Continuous Integration tools upstream issue

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2021 •
edited
Loading

Workflow Run URL

Python 3.9 Test Summary Info 
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-False-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-sum-True-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-False-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-None-prod-True-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-False-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-sum-True-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-False-bool_-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-float-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-float-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-int-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-int-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-float32-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-float32-2]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-bool_-1]
FAILED xarray/tests/test_duck_array_ops.py::test_min_count[None-True-x-prod-True-bool_-2]
@github-actions github-actions bot added the CI Continuous Integration tools label Oct 18, 2021
@mathause mathause mentioned this issue Oct 18, 2021
Merged
@dcherian dcherian mentioned this issue Oct 25, 2021
Closed
@mathause
Copy link
Collaborator

I think this is an upstream issue (or intended change).

import numpy as np
import pandas as pd

pd.Series([1.7, 0.5, np.nan]).sum(skipna=None)

returns 2.2 in pandas 1.3.4 and nan in main. Pandas is used to verify the result. That means that result is still correct in the test but expected has changed.

xarray/xarray/tests/test_duck_array_ops.py

Line 580 in fdabf3b

expected = series_reduce(da, func, skipna=skipna, dim=aggdim, min_count=min_count)

uses pandas

xarray/xarray/tests/test_duck_array_ops.py

Lines 262 to 263 in fdabf3b

se = da.to_series()
return from_series_or_scalar(getattr(se, func)(**kwargs))

I'll go check if this is reported upstream.

@mathause
Copy link
Collaborator

See pandas-dev/pandas#44178

@mathause mathause mentioned this issue Oct 26, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration tools upstream issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test-upstream] fix pd skipna=None mathause/xarray
1 participant
@mathause