Skip to content

groupby_bins problem in multidimensional-coords.ipynb #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smartlixx opened this issue Jun 7, 2022 · 1 comment · Fixed by #6672
Closed

groupby_bins problem in multidimensional-coords.ipynb #6670

smartlixx opened this issue Jun 7, 2022 · 1 comment · Fixed by #6672
Labels
contrib-good-first-issue topic-documentation

Comments

@smartlixx
Copy link
Contributor

What is your issue?

In multidimensional-coords.ipynb, the groupby_bins operation was on the coordinate xc, but the bins provided were from 0 to 90 and labeled as 'latitude center'. Based on groupby_bins document, the first argument is the variable to group on. I wonder if here it should be groupby_bins("yc") rather than groupby_bins("xc")? Please correct me if my understanding is wrong.
@smartlixx smartlixx added the needs triage Issue that has not been reviewed by xarray team member label Jun 7, 2022
@mathause
Copy link
Collaborator

mathause commented Jun 7, 2022 •
edited
Loading

I had a quick look at multidimensional-coords.ipynb and agree - that should be yc. We're happy to take a PR.

@mathause mathause added topic-documentation contrib-good-first-issue and removed needs triage Issue that has not been reviewed by xarray team member labels Jun 7, 2022
@smartlixx smartlixx mentioned this issue Jun 7, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib-good-first-issue topic-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update multidimensional-coords.ipynb smartlixx/xarray
2 participants
@mathause @smartlixx