Skip to content

Link to "the testing page of the wiki" is broken in contributing.rst #6687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taobrienlbl opened this issue Jun 10, 2022 · 5 comments
Closed

Comments

@taobrienlbl
Copy link
Contributor

What is your issue?

contributing.rst contains a link to "the testing page of the wiki" that goes instead to the main github page for xarray. The broken link is: https://github.com/pydata/xarray/wiki/Testing

Because of this, new contributors are unable to find information about "If your test requires working with files or network connectivity..."

@taobrienlbl taobrienlbl added the needs triage Issue that has not been reviewed by xarray team member label Jun 10, 2022
@mathause
Copy link
Collaborator

Thanks for the report - that might have been broken for a long time (I am not aware of any wiki ever existing). Therefore, I am not sure the information is actually present anywhere. But we are definitely interested to take a PR.

@mathause mathause added topic-documentation contrib-good-first-issue and removed needs triage Issue that has not been reviewed by xarray team member labels Jun 27, 2022
@0xSaksham
Copy link

@taobrienlbl I want to work on this issue, is there anything else relevant to the same that I must know of?

@taobrienlbl
Copy link
Contributor Author

@0xSaksham - nothing to add, except to specify that the link appears on lines 494-495 of doc/contributing.rst and that I confirm the link is still broken.

Cheers!

@tqa236
Copy link
Contributor

tqa236 commented Jan 16, 2024

Hello, I think this issue is resolved now, as mentioned in this thread: #7681 (comment)

The broken link is also no longer in the doc

@mathause
Copy link
Collaborator

Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants