Skip to content

count docstring mistakenly includes skipna #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
max-sixty opened this issue Feb 10, 2016 · 2 comments · Fixed by #4258
Closed

count docstring mistakenly includes skipna #755

max-sixty opened this issue Feb 10, 2016 · 2 comments · Fixed by #4258

Comments

@max-sixty
Copy link
Collaborator

Is this a mistake or am I missing something?

http://xray.readthedocs.org/en/stable/generated/xarray.DataArray.count.html?highlight=count#xarray.DataArray.count

skipna : bool, optional
If True, skip missing values (as marked by NaN). By default, only skips missing values for float dtypes; other dtypes either do not have a sentinel missing value (int) or skipna=True has not been implemented (object, datetime64 or timedelta64).

@shoyer
Copy link
Member

shoyer commented Feb 10, 2016

Yes, this is a mistake. We shouldn't be using this same template to generate the docstring for count.

@stale
Copy link

stale bot commented Jan 28, 2019

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity
If this issue remains relevant, please comment here; otherwise it will be marked as closed automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants