From e3a966034a753245c0bf3327584292f502088cc8 Mon Sep 17 00:00:00 2001 From: Mathias Hauser Date: Tue, 6 Oct 2020 16:29:18 +0200 Subject: [PATCH 1/4] remove pynio from py38 tests --- ci/requirements/py38.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/requirements/py38.yml b/ci/requirements/py38.yml index 7dff3a1bd97..e5c4e35c0a9 100644 --- a/ci/requirements/py38.yml +++ b/ci/requirements/py38.yml @@ -32,7 +32,6 @@ dependencies: - pip - pseudonetcdf - pydap - - pynio - pytest - pytest-cov - pytest-env From 1ff343e31a2a4dbb96dab4d0778237d20c77aff1 Mon Sep 17 00:00:00 2001 From: Mathias Hauser Date: Wed, 7 Oct 2020 20:05:09 +0200 Subject: [PATCH 2/4] remove pynio from other test envs --- ci/requirements/py36.yml | 2 +- ci/requirements/py37.yml | 2 +- ci/requirements/py38-all-but-dask.yml | 2 +- ci/requirements/py38.yml | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ci/requirements/py36.yml b/ci/requirements/py36.yml index 0200a7a8056..b33c71b7814 100644 --- a/ci/requirements/py36.yml +++ b/ci/requirements/py36.yml @@ -32,7 +32,7 @@ dependencies: - pip - pseudonetcdf - pydap - - pynio + # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env diff --git a/ci/requirements/py37.yml b/ci/requirements/py37.yml index 943ab755835..f23dd287bea 100644 --- a/ci/requirements/py37.yml +++ b/ci/requirements/py37.yml @@ -32,7 +32,7 @@ dependencies: - pip - pseudonetcdf - pydap - - pynio + # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env diff --git a/ci/requirements/py38-all-but-dask.yml b/ci/requirements/py38-all-but-dask.yml index 843d762b2fb..3eecc430b7e 100644 --- a/ci/requirements/py38-all-but-dask.yml +++ b/ci/requirements/py38-all-but-dask.yml @@ -29,7 +29,7 @@ dependencies: - pip - pseudonetcdf - pydap - - pynio + # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env diff --git a/ci/requirements/py38.yml b/ci/requirements/py38.yml index e5c4e35c0a9..8dc1d79250e 100644 --- a/ci/requirements/py38.yml +++ b/ci/requirements/py38.yml @@ -32,6 +32,7 @@ dependencies: - pip - pseudonetcdf - pydap + # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env From 6f9152f1251f8fe018acde4a473272c13ae1c16f Mon Sep 17 00:00:00 2001 From: Mathias Hauser Date: Wed, 7 Oct 2020 20:05:25 +0200 Subject: [PATCH 3/4] update docs --- doc/installing.rst | 5 +++-- doc/io.rst | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/installing.rst b/doc/installing.rst index 62e026e20a4..52820f8c11d 100644 --- a/doc/installing.rst +++ b/doc/installing.rst @@ -25,8 +25,9 @@ For netCDF and IO - `pydap `__: used as a fallback for accessing OPeNDAP - `h5netcdf `__: an alternative library for reading and writing netCDF4 files that does not use the netCDF-C libraries -- `pynio `__: for reading GRIB and other - geoscience specific file formats. Note that pynio is not available for Windows. +- `PyNIO `__: for reading GRIB and other + geoscience specific file formats. Note that PyNIO is not available for Windows and + that the PyNIO backend may be moved outside of xarray in the future. - `zarr `__: for chunked, compressed, N-dimensional arrays. - `cftime `__: recommended if you want to encode/decode datetimes for non-standard calendars or dates before diff --git a/doc/io.rst b/doc/io.rst index 956d9394653..1172b958f5d 100644 --- a/doc/io.rst +++ b/doc/io.rst @@ -1022,6 +1022,11 @@ We recommend installing PyNIO via conda:: conda install -c conda-forge pynio + .. note:: + + PyNIO is no longer actively maintained and conflicts with netcdf4 > 1.5.3. + The PyNIO backend may be moved outside of xarray in the future. + .. _PyNIO: https://www.pyngl.ucar.edu/Nio.shtml .. _io.PseudoNetCDF: From 617519572fda83bc9c32e4b28b8c401e6531be7f Mon Sep 17 00:00:00 2001 From: Mathias Hauser Date: Wed, 7 Oct 2020 20:11:04 +0200 Subject: [PATCH 4/4] Apply suggestions from code review --- ci/requirements/py36.yml | 2 +- ci/requirements/py37.yml | 2 +- ci/requirements/py38-all-but-dask.yml | 2 +- ci/requirements/py38.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ci/requirements/py36.yml b/ci/requirements/py36.yml index b33c71b7814..7c06bcb88f0 100644 --- a/ci/requirements/py36.yml +++ b/ci/requirements/py36.yml @@ -32,7 +32,7 @@ dependencies: - pip - pseudonetcdf - pydap - # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum + # - pynio: not compatible with netCDF4>1.5.3; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env diff --git a/ci/requirements/py37.yml b/ci/requirements/py37.yml index f23dd287bea..c9702deb4bf 100644 --- a/ci/requirements/py37.yml +++ b/ci/requirements/py37.yml @@ -32,7 +32,7 @@ dependencies: - pip - pseudonetcdf - pydap - # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum + # - pynio: not compatible with netCDF4>1.5.3; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env diff --git a/ci/requirements/py38-all-but-dask.yml b/ci/requirements/py38-all-but-dask.yml index 3eecc430b7e..547418ada66 100644 --- a/ci/requirements/py38-all-but-dask.yml +++ b/ci/requirements/py38-all-but-dask.yml @@ -29,7 +29,7 @@ dependencies: - pip - pseudonetcdf - pydap - # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum + # - pynio: not compatible with netCDF4>1.5.3; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env diff --git a/ci/requirements/py38.yml b/ci/requirements/py38.yml index 8dc1d79250e..b80b4fde6fd 100644 --- a/ci/requirements/py38.yml +++ b/ci/requirements/py38.yml @@ -32,7 +32,7 @@ dependencies: - pip - pseudonetcdf - pydap - # - pynio: not compatible with newest netCDF4; only tested in py36-bare-minimum + # - pynio: not compatible with netCDF4>1.5.3; only tested in py36-bare-minimum - pytest - pytest-cov - pytest-env