Skip to content

Conversation

@XinweiHe
Copy link

@XinweiHe XinweiHe commented Apr 2, 2025

Fixes #9112

@XinweiHe XinweiHe force-pushed the xinwei_support_gnn_explainer_hetero_v1 branch from 9c17868 to 49dfc7a Compare April 2, 2025 04:42
@XinweiHe XinweiHe force-pushed the xinwei_support_gnn_explainer_hetero_v1 branch from 8f81845 to 6312cc8 Compare April 2, 2025 04:54
@XinweiHe XinweiHe self-assigned this Apr 2, 2025
@XinweiHe XinweiHe force-pushed the xinwei_support_gnn_explainer_hetero_v1 branch from a2640db to 96ca2ba Compare April 2, 2025 04:58
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
Ok to merge once we add more tests.

Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, ideally, we can create three new internal classes, (one for base class, and one for each of homogenous and heterogeneous cases), and write these actual implementations in these two subclasses. This isn't blocking given the timeline though :)

@XinweiHe XinweiHe force-pushed the xinwei_support_gnn_explainer_hetero_v1 branch from 0ada1bf to 3b97c80 Compare April 4, 2025 07:30
@XinweiHe XinweiHe force-pushed the xinwei_support_gnn_explainer_hetero_v1 branch from 1d48e49 to 31a8476 Compare April 4, 2025 08:07
@XinweiHe
Copy link
Author

XinweiHe commented Apr 4, 2025

I think, ideally, we can create three new internal classes, (one for base class, and one for each of homogenous and heterogeneous cases), and write these actual implementations in these two subclasses.

will do in a follow-up.

@XinweiHe XinweiHe requested a review from akihironitta April 4, 2025 08:26
@akihironitta akihironitta changed the title Support hetero data for GNN Explainer Support hetero data in GNNExplainer Apr 4, 2025
@XinweiHe XinweiHe merged commit e7050f1 into master Apr 6, 2025
16 checks passed
@XinweiHe XinweiHe deleted the xinwei_support_gnn_explainer_hetero_v1 branch April 6, 2025 20:09
@XinweiHe XinweiHe changed the title Support hetero data in GNNExplainer Added support for heterogeneous graphs in GNNExplainer May 9, 2025
chrisn-pik pushed a commit to chrisn-pik/pytorch_geometric that referenced this pull request Jun 30, 2025
Fixes pyg-team#9112

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <[email protected]>
@rutujagurav
Copy link

In what version of pyg is/would be the GNNExplainer support for hetero graphs available?

@benstear
Copy link

Im also curious what version of pyg the GNNExplainer for heteroData will be available.

@akihironitta
Copy link
Member

@rutujagurav @benstear The change in this PR is included in 2.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Roadmap] Heterogeneous Graphs Explainability Support

6 participants