-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Enable getting global indices from SamplerOutput #10200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable getting global indices from SamplerOutput #10200
Conversation
cc3127a to
dce2fe6
Compare
Kh4L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10200 +/- ##
==========================================
- Coverage 86.11% 85.85% -0.26%
==========================================
Files 496 501 +5
Lines 33655 34507 +852
==========================================
+ Hits 28981 29625 +644
- Misses 4674 4882 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but ill let @akihironitta or @rusty1s review and merge this one
rusty1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose?
|
The purpose of these changes is to make it easier for users of |
ab5ae61 to
3b8b10e
Compare
2df71ab to
e6cbdf2
Compare
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging as per discussions with @rusty1s , these are heavily tested through NVIDIA already
The current implementation of SamplerOutput returns local indices of node ids in the
nodelist for therow,col,batch,orig_row, andorig_colfields. This leads to some confusion for using the edges/seed nodes retrieved from the sampler. This PR adds some helper methods that will derive the global indices for these fields given the information already stored within the SamplerOutput.Unittests have been also written for both homogeneous and heterogeneous outputs.