Skip to content

Conversation

@JeS24
Copy link
Contributor

@JeS24 JeS24 commented Apr 18, 2025

  • Grammatical fixes at some places.
  • Changed the first occurrence of "graph break" to "computational graph break" for clarity.

- Grammatical fixes at some places.
- Changed the first occurrence of "graph break" to "computational graph break" for clarity.
@JeS24 JeS24 requested a review from rusty1s as a code owner April 18, 2025 06:29
@akihironitta akihironitta merged commit 628242c into pyg-team:master Apr 18, 2025
1 of 3 checks passed
@akihironitta
Copy link
Member

Thank you for sending the fix! 🙏

@JeS24
Copy link
Contributor Author

JeS24 commented Apr 18, 2025

@akihironitta Thanks for the merge.

People usually call them graph breaks

True. I debated that edit for a while. My intention was to clearly differentiate between 'computational graphs' and 'combinatorial graphs', or graph datasets, since both appear in the context of PyG, even though they are fundamentally different objects. Just to avoid any possible confusion.

chrisn-pik pushed a commit to chrisn-pik/pytorch_geometric that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants