-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add Relational Deep Learning example #10230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
vid-koci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Any comments that I've had I've just directly changed in the code.
wsad1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
rusty1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice!
Co-authored-by: Matthias Fey <[email protected]>
Co-authored-by: Matthias Fey <[email protected]>
Co-authored-by: Matthias Fey <[email protected]>
for more information, see https://pre-commit.ci
|
@rusty1s Incorporated your comments The example now includes the logic for going from task -> input to the model, and the only heavy lifting logic still borrowed from RelBench is: Should we try to move this logic into the example as well? Might be tricker to do and personally I'm okay with this utility being imported from relbench. |
|
added a minor change to have a readme sentence about this example since i think its worth drawing attention to. feel free to modify as you all see fit |
Co-authored-by: Vid Kocijan <[email protected]> Co-authored-by: Jinu Sunil <[email protected]> Co-authored-by: Rishi Puri <[email protected]> Co-authored-by: Matthias Fey <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
Uses
relbenchandtorchframeto demonstrate relational deep learning end to end.