Skip to content

Conversation

@BlazStojanovic
Copy link
Contributor

Uses relbench and torchframe to demonstrate relational deep learning end to end.

@BlazStojanovic BlazStojanovic requested a review from wsad1 as a code owner April 26, 2025 00:33
Copy link
Contributor

@vid-koci vid-koci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Any comments that I've had I've just directly changed in the code.

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

@BlazStojanovic
Copy link
Contributor Author

@rusty1s Incorporated your comments

The example now includes the logic for going from task -> input to the model, and the only heavy lifting logic still borrowed from RelBench is:

    data, col_stats_dict = make_pkey_fkey_graph(
        ...
    )

Should we try to move this logic into the example as well? Might be tricker to do and personally I'm okay with this utility being imported from relbench.

@puririshi98
Copy link
Contributor

added a minor change to have a readme sentence about this example since i think its worth drawing attention to. feel free to modify as you all see fit

@akihironitta akihironitta enabled auto-merge (squash) May 13, 2025 15:04
@akihironitta akihironitta changed the title Simple RDL example script Add Relational Deep Learning example May 13, 2025
@akihironitta akihironitta disabled auto-merge May 13, 2025 15:05
@akihironitta akihironitta enabled auto-merge (squash) May 13, 2025 15:05
@akihironitta akihironitta merged commit fed2253 into pyg-team:master May 13, 2025
17 of 18 checks passed
chrisn-pik pushed a commit to chrisn-pik/pytorch_geometric that referenced this pull request Jun 30, 2025
Co-authored-by: Vid Kocijan <[email protected]>
Co-authored-by: Jinu Sunil <[email protected]>
Co-authored-by: Rishi Puri <[email protected]>
Co-authored-by: Matthias Fey <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants