Fix NumPy deprecations and enforce CI failure on warnings #10283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
emmanuel-ferdman
requested review from
a team,
mananshah99 and
wsad1
as code owners
Member
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
Thanks, this is great! Could we also fail the CI when there's DeprecationWarning raised from our tests by listing the warning here?
pytorch_geometric/pyproject.toml
Line 194 in 272a844
Member
|
It'd be good to update the changelog as well. |
Signed-off-by: Emmanuel Ferdman <[email protected]>
emmanuel-ferdman
changed the title
Contributor
Author
|
@akihironitta sure, added all 😄 |
Member
|
Sorry about the delay. Thanks, I'll check during the weekend :) |
…geometric into emmanuel-ferdman/master
akihironitta
approved these changes
Jun 7, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10283 +/- ##
==========================================
- Coverage 86.11% 85.58% -0.53%
==========================================
Files 496 498 +2
Lines 33655 34146 +491
==========================================
+ Hits 28981 29223 +242
- Misses 4674 4923 +249 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrisn-pik
pushed a commit
to chrisn-pik/pytorch_geometric
that referenced
this pull request
Jun 30, 2025
…0283) Co-authored-by: Rishi Puri <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This small PR resolves deprecation warnings caused by the use of
numpy.in1d:Please note that
in1dis deprecated from NumPy 1.19.0 and removed in 2.0.0.isinavailable since Python 1.13.0.