-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add ProteinMPNN model and example
#10289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10289 +/- ##
==========================================
- Coverage 86.11% 85.64% -0.47%
==========================================
Files 496 499 +3
Lines 33655 34297 +642
==========================================
+ Hits 28981 29373 +392
- Misses 4674 4924 +250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
@jdhenaos plz share your large dataset training log here, thanks:) |
Large dataset training log |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
|
left comments on the existing threads, please address and I will be ready to merge once comments addressed and CI is passing |
|
@puririshi98 new ci tests work fine on 25.05 pyg container |
|
@xnuohz thanks for double checking! I have reinstalled the Docker image and rerun the test. However, the probe for |
|
my advice would be to run the full unit tests inside the latest nvidia container everytime this branch needs an update from master branch, and when you get clean passing lmk ill merge once your local tests and the github website CI are both green |
|
I was running a new round of CI tests. However, I encountered an error in |
this seems unrelated to us, hopefully it goes away with the new 25.07 container coming end of july, or you can file an issue with transformers and see if they fix it |
|
hi @puririshi98 CI becomes green, can you merge? |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now

Feature summary
ProteinMPNNDatasetincludes 2 versions (small and large)ProteinMPNNIssue
ProtienMPNN(inverse AlphaFold): Dataset+Model+Unit tests+Example #9701Usage
python examples/llm/protein_mpnn.py --gradient_norm 5 --mixed_precision TrueHighlight
Small dataset training log