-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add NodeFormer model and example
#10409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ic into models/nodeformer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10409 +/- ##
==========================================
- Coverage 86.11% 85.06% -1.05%
==========================================
Files 496 511 +15
Lines 33655 36250 +2595
==========================================
+ Hits 28981 30836 +1855
- Misses 4674 5414 +740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@xnuohz plz get CI passing |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just get CI green
|
@rusty1s @akihironitta @wsad1 ready for final review/merge |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xnuohz can you explain where we are ensuring attention is not being done across the full minibatch? we should be utilizing the batch tensor, no? (remember what we had to change for sgformer)
…ic into models/nodeformer
Head branch was pushed to by a user without write access
Issue
Usage
Highlight
Result