-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix broken datasets url #10415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix broken datasets url #10415
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10415 +/- ##
==========================================
- Coverage 86.11% 85.09% -1.02%
==========================================
Files 496 510 +14
Lines 33655 35964 +2309
==========================================
+ Hits 28981 30604 +1623
- Misses 4674 5360 +686 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you plz merge? @wsad1 |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once you fix changelog, please share logs for a succesful run of each of these tests using https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pyg/tags.
I asked since github CI skips them
|
@akihironitta @rusty1s @wsad1 looks like i cant merge this one, lgtm |
|
Hi, came here because #10510 since I am currently participating in the TopoBench Challenge. For the Twitch case, I think the current implementation has a Bug The data file from https://snap.stanford.edu/data/twitch.zip has a different naming convention for the English and Portuguese, which is why the current implementation fails for those cases. The folder for English is named "ENGB" and the one for Portuguese is "PTBR".
|
|
@Mullerio thanks for pointing that out, fixed. |


Close #10346, #10510, #10396, #10525