Skip to content

Conversation

@xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Aug 13, 2025

@xnuohz xnuohz requested a review from wsad1 as a code owner August 13, 2025 17:17
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.09%. Comparing base (c211214) to head (a3aa4f9).
⚠️ Report is 142 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10415      +/-   ##
==========================================
- Coverage   86.11%   85.09%   -1.02%     
==========================================
  Files         496      510      +14     
  Lines       33655    35964    +2309     
==========================================
+ Hits        28981    30604    +1623     
- Misses       4674     5360     +686     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yfiua
Copy link

yfiua commented Aug 25, 2025

Can you plz merge? @wsad1

Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you fix changelog, please share logs for a succesful run of each of these tests using https://catalog.ngc.nvidia.com/orgs/nvidia/containers/pyg/tags.
I asked since github CI skips them

@xnuohz
Copy link
Contributor Author

xnuohz commented Sep 9, 2025

image

@puririshi98
Copy link
Contributor

@akihironitta @rusty1s @wsad1 looks like i cant merge this one, lgtm

@Mullerio
Copy link

Mullerio commented Nov 7, 2025

Hi, came here because #10510 since I am currently participating in the TopoBench Challenge.

For the Twitch case, I think the current implementation has a Bug

The data file from https://snap.stanford.edu/data/twitch.zip has a different naming convention for the English and Portuguese, which is why the current implementation fails for those cases.

The folder for English is named "ENGB" and the one for Portuguese is "PTBR".

grafik

@xnuohz
Copy link
Contributor Author

xnuohz commented Nov 8, 2025

@Mullerio thanks for pointing that out, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken dataset download

4 participants