Add is_sparse and to_torch_coo_tensor
#6003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6003 +/- ##
==========================================
- Coverage 86.64% 84.67% -1.97%
==========================================
Files 361 360 -1
Lines 19860 19860
==========================================
- Hits 17207 16816 -391
- Misses 2653 3044 +391
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
68 tasks
rusty1s
reviewed
Nov 18, 2022
Member
rusty1s
left a comment
rusty1s
left a comment
There was a problem hiding this comment.
LGTM besides the missing test of to_sparse_coo_tensor. Do you plan to integrate that in this PR?
Contributor
Author
|
Yep, will finish it tomorrow. |
rusty1s
approved these changes
Nov 21, 2022
rusty1s
reviewed
Nov 21, 2022
rusty1s
reviewed
Nov 21, 2022
jjpietrak
pushed a commit
to jjpietrak/pytorch_geometric
that referenced
this pull request
Nov 25, 2022
This PR aims to + Add `is_sparse` to check if the input is either `torch.sparse.Tensor` or `torch_sparse.SparseTensor` + Add `to_torch_coo_tensor` to convert `edge_index` and `edge_weight` to `torch.sparse.Tensor` (in COO format) + Move `is_torch_sparse_tensor` from `torch_sparse_tensor.py` to `sparse.py`. I think this makes the structure in `torch_geometric.utils` clearer. + Clean up duplicated code in `message_passing.py`. Co-authored-by: rusty1s <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to
is_sparseto check if the input is eithertorch.sparse.Tensorortorch_sparse.SparseTensorto_torch_coo_tensorto convertedge_indexandedge_weighttotorch.sparse.Tensor(in COO format)is_torch_sparse_tensorfromtorch_sparse_tensor.pytosparse.py. I think this makes the structure intorch_geometric.utilsclearer.message_passing.py.