-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Adding trim_to_layer utility function
#6661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rusty1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I have a few questions:
- Can we split this PR into multiple such that we first integrate
sampled_infointo theNeighborLoaderbefore we think about integration inMessagePassing/benchmark scripts? - I am not entirely sure why we need the concept of a
HierarchicalSparseTensor. Can't we just letNeighborLoaderreturn a list of sliced edge indices/sparse tensors? - I would like to avoid adding any logic of this to
MessagePassingand its instances. IMO, any customization ofxandedge_indexshould happen outside of it. Would that be possible?
Thanks @rusty1s for the review. Let's proceed first with pyg-lib part. |
It's enabling the hierarchical tensor usage and significant performance improvement PyG part: pyg-team/pytorch_geometric#6661 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: rusty1s <[email protected]>
to significantly improve performance
28bba95 to
cc036d8
Compare
trim_to_layer utility function
Codecov Report
@@ Coverage Diff @@
## master #6661 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 431 432 +1
Lines 23458 23498 +40
=======================================
+ Hits 21455 21492 +37
- Misses 2003 2006 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adding hierarchical graph adjacency matrix feature to significantly improve performance
Contributors: @rBenke @andreazanetti