Fix data.num_edges for torch.sparse.Tensor
#7104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zero `num_edges` when using native PyTorch sparse tensor.
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7104 +/- ##
==========================================
- Coverage 91.66% 91.25% -0.42%
==========================================
Files 436 436
Lines 23914 23913 -1
==========================================
- Hits 21921 21821 -100
- Misses 1993 2092 +99
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
EdisonLeeeee
reviewed
Apr 3, 2023
Contributor
EdisonLeeeee
left a comment
EdisonLeeeee
left a comment
There was a problem hiding this comment.
Thank you for catching!
torch_geometric/data/storage.py
Outdated
| for value in self.values('adj', 'adj_t'): | ||
| if isinstance(value, SparseTensor): | ||
| return value.nnz() | ||
| elif isinstance(value, Tensor) and (value.is_sparse |
Contributor
There was a problem hiding this comment.
Can we use torch_geometric.utils.is_torch_sparse_tensor instead?
rusty1s
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes zero
num_edgeswhen using native PyTorch sparse tensor (#7103).