-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Consolidate ogbn-papers100M and ogbn-products examples and increase test acc to 61.76%
#9467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate ogbn-papers100M and ogbn-products examples and increase test acc to 61.76%
#9467
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
2. Add undirected graph on ogbn-products with Sage model 3. Add undirected graph on ogbn-products with GAT model
…ub/pytorch_geometric into performance_analysis
for more information, see https://pre-commit.ci
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🚀
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make sure the filenames are updated in the entire repo, e.g.,
$ git grep ogbn_products_sage.py
README.md:- **[SAGEConv](https://pytorch-geometric.readthedocs.io/en/latest/generated/torch_geometric.nn.conv.SAGEConv.html)** from Hamilton *et al.*: [Inductive Representation Learning on Large Graphs](https://arxiv.org/abs/1706.02216) (NIPS 2017) \[[**Example1**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/reddit.py), [**Example2**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/ogbn_products_sage.py), [**Example3**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/graph_sage_unsup.py), [**Example4**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/graph_sage_unsup_ppi.py)\]
README.md:- **[NeighborLoader](https://pytorch-geometric.readthedocs.io/en/latest/modules/loader.html#torch_geometric.loader.NeighborLoader)** from Hamilton *et al.*: [Inductive Representation Learning on Large Graphs](https://arxiv.org/abs/1706.02216) (NIPS 2017) \[[**Example1**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/reddit.py), [**Example2**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/ogbn_products_sage.py), [**Example3**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/ogbn_products_gat.py), [**Example4**](https://github.com/pyg-team/pytorch_geometric/blob/master/examples/hetero/to_hetero_mag.py)\]
torch_geometric/loader/neighbor_sampler.py: `examples/ogbn_products_sage.py
torch_geometric/loader/neighbor_sampler.py: ogbn_products_sage.py>`_.Co-authored-by: Akihiro Nitta <[email protected]>
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once all the comments are addressed. Great work!
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once comments are resolved, LGTM! Let's also make sure all filenames are updated in the repo as I commented in #9467 (review).
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
|
@rusty1s @akihironitta anything else needed to merge? |
ogbn-papers100M and ogbn-products examples
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Improve the test accuracy to >60% on ogbn-papers100M consolidate repetitive examples
I also modified the PR title and the changelog as the test metric >60% reported in the PR description is likely to be the highest metric evaluated and picked across all epochs. Feel free to adjust it back if the reported metric is the actual test metric.
ogbn-papers100M and ogbn-products examplesogbn-papers100M and ogbn-products examples and increase test acc to 61.76%
Improve the test accuracy to >60% on ogbn-papers100M consolidate repetitive examples