[ENH] Allow users to pass edge_weight to GraphUNet model
#9737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Oct 28, 2024
rusty1s
changed the title
edge_weight to GraphUNet model
Contributor
Author
|
Hi @rusty1s, Thanks for looking into this. However, I don't think the PR was ready to be merged (my bad for making it ready on GitHub). There is an issue where the multiplication of the adjacency matrix with itself doesn't work because it is a sparse matrix. I will open a new issue with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9736.
This PR:
edge_weightparameter to thenn.models.GraphUNetmodel's forward function, so that users can provide an initial weights vector.edge_weightdefault toNone.edge_weightto ones if it isNone. This ensures functionality stays the same by default.edge_weightis given by the user, its size is checked before running any of the code.