Skip to content

Conversation

@ybubnov
Copy link
Contributor

@ybubnov ybubnov commented Oct 29, 2024

This patch adds support of torch_delaunay package, which works with Torch tensors. The new implementation uses torch_delaunay package if it is installed (by default), and then falls back to the scipy implementation otherwise.

@ybubnov ybubnov requested a review from wsad1 as a code owner October 29, 2024 22:38
This patch adds support of torch_delaunay package, which works
with Torch tensors. The new implementation uses `torch_delaunay` package
if it is installed (by default), and then falls back to the `scipy`
implementation otherwise.
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool :)

@rusty1s rusty1s changed the title Add support for torch_delaunay package Add support for torch_delaunay package in Delaunay transformation Nov 13, 2024
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (f5c8293) to head (6633224).
Report is 68 commits behind head on master.

Files with missing lines Patch % Lines
torch_geometric/transforms/delaunay.py 86.84% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9748      +/-   ##
==========================================
- Coverage   88.13%   87.32%   -0.81%     
==========================================
  Files         482      482              
  Lines       31421    31451      +30     
==========================================
- Hits        27693    27466     -227     
- Misses       3728     3985     +257     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s merged commit 610688e into pyg-team:master Nov 13, 2024
18 checks passed
@ybubnov ybubnov deleted the torch-delaunay branch November 13, 2024 09:30
mattjhayes3 pushed a commit to mattjhayes3/pytorch_geometric that referenced this pull request Dec 14, 2024
…pyg-team#9748)

This patch adds support of torch_delaunay package, which works with
Torch tensors. The new implementation uses `torch_delaunay` package if
it is installed (by default), and then falls back to the `scipy`
implementation otherwise.

---------

Co-authored-by: rusty1s <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants