Fix utils.group_cat concatenating dimension
#9766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
tzuhanchang
changed the title
torch_geometric.utils.group_cat concatenation dimutils.group_cat concatenating dimension
mattjhayes3
pushed a commit
to mattjhayes3/pytorch_geometric
that referenced
this pull request
Dec 14, 2024
Before the fix, tensors can only be concatenated over `dim=0`. The `dim` argument was not used by any operation in the function. This update allows the tensors to be concatenated over any given dimension. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, tensors can only be concatenated over
dim=0. Thedimargument was not used by any operation in the function. This update allows the tensors to be concatenated over any given dimension.