Skip to content

Conversation

@sbhavani
Copy link
Contributor

@sbhavani sbhavani commented Nov 16, 2024

Updated to use new NGC CUDA DL base image. Some differences:

  1. /workspace is the working directory
  2. Removing deprecated Python libs that were not included in NGC PyG image:
    torch_scatter torch_sparse torch_cluster torch_spline_conv torchnet==0.0.4 h5py torchnet
    Most users wont need these and leaving them off saves lots of space. if they do need them it makes more sense to download them as needed on the fly
  3. Using latest stable versions for graphviz and torch

@puririshi98 puririshi98 self-requested a review November 19, 2024 17:10
@puririshi98
Copy link
Contributor

will merge once @sbhavani has tests passing locally

@puririshi98 puririshi98 enabled auto-merge (squash) December 6, 2024 18:21
Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM.
the goal is to mirror the docker build nvidia uses for its container
================================================= 6146 passed, 766 skipped, 167 warnings in 123.78s (0:02:03) ==================================================

@puririshi98 puririshi98 merged commit bd5ae45 into pyg-team:master Dec 6, 2024
16 checks passed
mattjhayes3 pushed a commit to mattjhayes3/pytorch_geometric that referenced this pull request Dec 14, 2024
Updated to use new NGC CUDA DL base image. Some differences:

1. /workspace is the working directory
2. Python libs removed that were not included in NGC PyG image:
`torch_scatter torch_sparse torch_cluster torch_spline_conv
torchnet==0.0.4 h5py torchnet `
3. Using latest stable versions for graphviz and torch

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rishi Puri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants