-
Notifications
You must be signed in to change notification settings - Fork 3.9k
On single-CPU systems, skip tests which are known not to work #9817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. On AWS instances of type I've modified the patch to use |
…tests requiring more than one Otherwise test_cpu_affinity_neighbor_loader() fails in this way: E ValueError: More workers (got 2) than available cores (got 1) and test_multithreading_neighbor_loader() fails in this way: E ValueError: 'worker_threads' should be smaller than the total available number of threads 1 (got 2)
Head branch was pushed to by a user without write access
|
Thank you. I'm also changing slightly the wording of the commit message to be in line with the wording of the code. |
All commits are squashed into one when merging the PR, so it doesn't matter much, but thank you! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9817 +/- ##
==========================================
- Coverage 86.11% 85.79% -0.32%
==========================================
Files 496 498 +2
Lines 33655 34132 +477
==========================================
+ Hits 28981 29284 +303
- Misses 4674 4848 +174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…am#9817) Co-authored-by: Akihiro Nitta <[email protected]>
Hello. While building this package on a single-CPU system I noticed that two tests fail.
test_cpu_affinity_neighbor_loader()fails in this way:E ValueError: More workers (got 2) than available cores (got 1)and
test_multithreading_neighbor_loader()fails in this way:E ValueError: 'worker_threads' should be smaller than the total available number of threads 1 (got 2)I guess those tests are simply not suitable to be executed on single-CPU systems, so the proposed MR uses
os.cpu_count()to test before executing them.The failures may be reproduced easily by booting with
GRUB_CMDLINE_LINUX="nr_cpus=1".Thanks.