MedShapeNet and example #9823
Merged
MedShapeNet and example #9823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
“MedShapeNet is not divided by train and test by default. Therefore, train data is downloaded from the first n required number of samples, and the test data is downloaded from the last n required number of samples.” i would recommend the data be split randomly if train/val/test is not predefined |
Contributor
note that CI is also failing with this issue. however, I am having trouble installing medshapenet through pip to verify if your code actually works. Is that how you install it? could you provide your setup commands? based on this i will also advise wether those instructions should be included in your code somewhere (i will decide based on the complexity of the set up instructions) |
jdhenaos
force-pushed
the
medshapenet
branch
from
0825c61 to
e2f7faf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9823 +/- ##
==========================================
- Coverage 86.11% 85.43% -0.68%
==========================================
Files 496 496
Lines 33655 34007 +352
==========================================
+ Hits 28981 29055 +74
- Misses 4674 4952 +278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jdhenaos
force-pushed
the
medshapenet
branch
from
237bd37 to
e2f7faf
Compare
jdhenaos
force-pushed
the
medshapenet
branch
from
a20df74 to
8a1e2d4
Compare
jdhenaos
force-pushed
the
medshapenet
branch
from
85fda59 to
1da4e60
Compare
jdhenaos
force-pushed
the
medshapenet
branch
from
9a25a82 to
028ff15
Compare
jdhenaos
force-pushed
the
medshapenet
branch
from
7feffdb to
73e96d3
Compare
jdhenaos
force-pushed
the
medshapenet
branch
from
75d9ce2 to
033987e
Compare
Contributor
|
Should it be |
Contributor
Author
|
Indeed, The problem is that MedShapeNet uses a down-grade version of numpy. By default, it downloads version I'm not sure how to proceed with this conflict. Any hint you can give will be welcome. |
Contributor
Author
|
@xnuohz and @puririshi98 I have talked with the MedShapeNet. Looks like they already solved the problem, I was able to run the Dataset on Python 3.10.12. Please corroborate and let me know if there is some pending issue to solve |
Contributor
Author
|
Thanks for your time checking the code and adding the last suggestions. I have already worked in the suggested changes:
|
Contributor
|
@jdhenaos thank you. can you share the train log? |
Contributor
Author
|
@xnuohz the train log: |
xnuohz
reviewed
May 5, 2025
Contributor
xnuohz
left a comment
xnuohz
left a comment
There was a problem hiding this comment.
add an unit test if the dataset is small and easy to download
puririshi98
approved these changes
May 22, 2025
Contributor
puririshi98
left a comment
puririshi98
left a comment
There was a problem hiding this comment.
lgtm will merge once CI passes
chrisn-pik
pushed a commit
to chrisn-pik/pytorch_geometric
that referenced
this pull request
Jun 30, 2025
I have added MedShapeNet dataset, adding eight classes. The next folders were ignored from MedShapeNet Dataset due to a lack of samples: ASOCA (n=43) AVT (n=45) AutoImplantCraniotomy (n=14) FaceVR (n=14) This Dataset requires a size number as a parameter to download the same number of samples per shape to ensure class balance. MedShapeNet is not divided by train and test by default. Therefore, train data is downloaded from the first n required number of samples, and the test data is downloaded from the last n required number of samples. dgcnn classification example was modified to use both ModelNet and MedShapeNet. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Rishi Puri <[email protected]> Co-authored-by: Rishi Puri <[email protected]>
akihironitta
reviewed
Oct 3, 2025
|
|
||
| subset = [] | ||
| for dataset in list_of_datasets: | ||
| self.newpath = self.root + '/' + dataset.split("/")[1] |
Member
There was a problem hiding this comment.
I got to this PR while reviewing #10472. Does this work on Windows? Could we make it os-agnostic?
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added MedShapeNet dataset, adding eight classes.
The next folders were ignored from MedShapeNet Dataset due to a lack of samples:
ASOCA (n=43)
AVT (n=45)
AutoImplantCraniotomy (n=14)
FaceVR (n=14)
This Dataset requires a size number as a parameter to download the same number of samples per shape to ensure class balance.
MedShapeNet is not divided by train and test by default. Therefore, train data is downloaded from the first n required number of samples, and the test data is downloaded from the last n required number of samples.
dgcnn classification example was modified to use both ModelNet and MedShapeNet.