-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add Polynormer model and example [1/n]
#9908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
… into models/sgformer
for more information, see https://pre-commit.ci
…ic into models/polynormer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9908 +/- ##
==========================================
- Coverage 86.11% 85.71% -0.40%
==========================================
Files 496 501 +5
Lines 33655 34454 +799
==========================================
+ Hits 28981 29532 +551
- Misses 4674 4922 +248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please share a log of running the example
|
@rusty1s thanks for your review, resolved and increased code coverage. linting error not related to my changes. |
|
@xnuohz can you see if you can fix the CI issue it might be that the explainer test runs somethjing based on models available in pyg and you have added a new model |
|
@puririshi98 waiting #10310 to fix and merge |
okay perfect analysis, this isnt on you. i will merge this once those go in and CI becomes green |
|
hi @puririshi98 CI becomes green, can you merge? |
puririshi98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just wondering why there are changes to appnp, what does this have to do with polynormer?
|
CI may fail when torch.allclose uses default parameters, changing these default parameters allows CI to pass |
Invalid email address
Issue
Usage
python examples/polynormer.py --post_bnHighlight
First round of benchmarks run on NVIDIA internal computers
![Uploading image.png…]()