Skip to content

Conversation

@xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Jan 1, 2025

Issue

Usage

python examples/polynormer.py --post_bn

Highlight

image
image

First round of benchmarks run on NVIDIA internal computers
Uploading image.png…

@xnuohz xnuohz mentioned this pull request Jan 1, 2025
7 tasks
@codecov
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.71%. Comparing base (c211214) to head (ed3f1d5).
⚠️ Report is 117 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9908      +/-   ##
==========================================
- Coverage   86.11%   85.71%   -0.40%     
==========================================
  Files         496      501       +5     
  Lines       33655    34454     +799     
==========================================
+ Hits        28981    29532     +551     
- Misses       4674     4922     +248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please share a log of running the example

@xnuohz
Copy link
Contributor Author

xnuohz commented May 30, 2025

@rusty1s thanks for your review, resolved and increased code coverage. linting error not related to my changes.

@puririshi98
Copy link
Contributor

@xnuohz can you see if you can fix the CI issue it might be that the explainer test runs somethjing based on models available in pyg and you have added a new model

@xnuohz
Copy link
Contributor Author

xnuohz commented Jun 11, 2025

@puririshi98 waiting #10310 to fix and merge
also checkout this pr, same ci error as mine

@puririshi98
Copy link
Contributor

@puririshi98 waiting #10310 to fix and merge also checkout this pr, same ci error as mine

okay perfect analysis, this isnt on you. i will merge this once those go in and CI becomes green

@xnuohz
Copy link
Contributor Author

xnuohz commented Jul 2, 2025

hi @puririshi98 CI becomes green, can you merge?

Copy link
Contributor

@puririshi98 puririshi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just wondering why there are changes to appnp, what does this have to do with polynormer?

@xnuohz
Copy link
Contributor Author

xnuohz commented Jul 3, 2025

CI may fail when torch.allclose uses default parameters, changing these default parameters allows CI to pass

@puririshi98 puririshi98 enabled auto-merge (squash) July 3, 2025 21:35
@puririshi98 puririshi98 disabled auto-merge July 3, 2025 21:38
@puririshi98 puririshi98 enabled auto-merge (squash) July 3, 2025 21:40
auto-merge was automatically disabled July 3, 2025 21:43

Invalid email address

@puririshi98 puririshi98 merged commit 9af3ced into pyg-team:master Jul 3, 2025
19 checks passed
@xnuohz xnuohz deleted the models/polynormer branch July 4, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants