Cugraph Examples Updates #9953
Cugraph Examples Updates #9953
Conversation
Update cugraph examples
|
@guanxingithub, as mentioned before please delete the old cugraph examples that you based these new files on, otherwise there will be duplicates. |
|
also please attach logs of these scripts running succesfully on your setup for review |
…nd ogbn_train_cugraph_multigpu.py
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
Great work @guanxingithub! This is not blocking you from merging this PR, but what would be so nice before merging this PR would be to profile some parts of the scripts and make sure there's no basic inefficient code :)
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
Nice work! I'd like these cugraph examples to be as performant as possible :) Let's merge this once comments are addressed and this PR is cleaned up :)
|
@akihironitta reviewing the profile by @guanxingithub, it does not seem like there are any bottlenecks, i will leave to you to decide if we can merge if this investigation satisfies your concerns |
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
Can you also make sure README.md also gets updated?
There was a problem hiding this comment.
@puririshi98 I'm not sure you have already, but would you mind reviewing this PR as well?
|
i have but ill do another omnday |
good catch |
_multigpu.py ending is redundant since its in multigpu folder
for more information, see https://pre-commit.ci
puririshi98
left a comment
puririshi98
left a comment
There was a problem hiding this comment.
LGTM, was also reviewed by Alexandria, our cugraph expert. @akihironitta lmk if anything else needed to merge
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
@guanxingithub @puririshi98 @alexbarghi-nv Thanks for bearing with me ❤️ I'll test this out and get it merged tonight!
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
Haven't managed to run, but LGTM!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
3 participants
We consolidate cugraph training with
Models: GAT, GCN, GraphSAGE
Datasets: ogbn-arxiv, ogbn-products, ogbn-papers100M
examples/ogbn_train_cugraph.py is the script for single gpu training
examples/multi_gpu/ogbn_train_cugraph_multigpu.py is the script for multiple gpu training.