Update docs, update error message, pin astroid version to a non-broken version

Author: oddbookworm

buildconfig/stubs/pygame/transform.pyi

@@ -463,7 +463,7 @@ def hsl(
 def pixelate(
     surface: Surface,
     pixel_size: int,
-    dest_surface: Optional[Surface] = None
+    dest_surface: Optional[Surface] = None,
 ) -> Surface:
     """Returns a pixelated version of the original surface.
 

pyproject.toml

@@ -60,6 +60,7 @@ requires = [
   "sphinx<=8.1.3",
   "sphinx-autoapi<=3.3.2",
   "pyproject-metadata!=0.9.1",
+  "astroid<=3.3.8",
 ]
 build-backend = 'mesonpy'
 

src_c/transform.c

@@ -137,7 +137,7 @@ newsurf_fromsurf(SDL_Surface *surf, int width, int height)
     /* Copy palette, colorkey, etc info */
     if (SDL_ISPIXELFORMAT_INDEXED(PG_SURF_FORMATENUM(surf))) {
         SDL_Palette *newsurf_palette = PG_GetSurfacePalette(newsurf);
-        SDL_Palette *surf_palette = PG_GetSurfacePalette(newsurf);
+        SDL_Palette *surf_palette = PG_GetSurfacePalette(surf);
 
         if (newsurf_palette == NULL) {
             PyErr_SetString(
@@ -4248,13 +4248,13 @@ surf_pixelate(PyObject *self, PyObject *args, PyObject *kwargs)
 
     if (testWidth > INT_MAX || testWidth <= 0) {
         PyErr_SetString(PyExc_OverflowError,
-                        "Cannot scale width outside the range [0, INT_MAX]");
+                        "Cannot scale width outside the range (0, INT_MAX]");
         return NULL;
     }
 
     if (testHeight > INT_MAX || testHeight <= 0) {
         PyErr_SetString(PyExc_OverflowError,
-                        "Cannot scale height outside the range [0, INT_MAX]");
+                        "Cannot scale height outside the range (0, INT_MAX]");
         return NULL;
     }