[Backport maintenance/4.0.x] Add Enum dunder to the list of allowed dunder (#10725)

Add Enum dunder to the list of allowed dunder (#10722)



(cherry picked from commit 0426f8b)

Co-authored-by: Trinh Quoc Anh <[email protected]>
Co-authored-by: Pierre Sassoulas <[email protected]>
Co-authored-by: Mark Byrne <[email protected]>

Author: 4 people

doc/whatsnew/fragments/10435.false_positive

@@ -0,0 +1,3 @@
+Add Enum dunder methods ``_generate_next_value_``, ``_missing_``, ``_numeric_repr_``, ``_add_alias_``, and ``_add_value_alias_`` to the list passed to ``--good-dunder-names``.
+
+Closes #10435

pylint/constants.py

@@ -219,26 +219,31 @@ def _get_pylint_home() -> str:
         "__anext__": "Use anext built-in function",
     },
 }
-
-EXTRA_DUNDER_METHODS = [
-    "__new__",
-    "__subclasses__",
-    "__init_subclass__",
-    "__set_name__",
-    "__class_getitem__",
-    "__missing__",
-    "__exit__",
-    "__await__",
-    "__aexit__",
-    "__getnewargs_ex__",
-    "__getnewargs__",
-    "__getstate__",
-    "__index__",
-    "__setstate__",
-    "__reduce__",
-    "__reduce_ex__",
-    "__post_init__",  # part of `dataclasses` module
-]
+EXTRA_DUNDER_METHODS: dict[tuple[int, int], list[str]] = {
+    (0, 0): [
+        "__new__",
+        "__subclasses__",
+        "__init_subclass__",
+        "__set_name__",
+        "__class_getitem__",
+        "__missing__",
+        "__exit__",
+        "__await__",
+        "__aexit__",
+        "__getnewargs_ex__",
+        "__getnewargs__",
+        "__getstate__",
+        "__index__",
+        "__setstate__",
+        "__reduce__",
+        "__reduce_ex__",
+        "__post_init__",  # part of `dataclasses` module
+        "_generate_next_value_",
+        "_missing_",
+        "_numeric_repr_",
+    ],
+    (3, 13): ["_add_alias_", "_add_value_alias_"],
+}
 
 DUNDER_PROPERTIES = [
     "__class__",

pylint/extensions/dunder.py

@@ -41,11 +41,10 @@ class DunderChecker(BaseChecker):
     )
 
     def open(self) -> None:
-        self._dunder_methods = (
-            EXTRA_DUNDER_METHODS
-            + DUNDER_PROPERTIES
-            + self.linter.config.good_dunder_names
-        )
+        self._dunder_methods = DUNDER_PROPERTIES + self.linter.config.good_dunder_names
+        for since_vers, extra_dunder_methods in EXTRA_DUNDER_METHODS.items():
+            if since_vers <= self.linter.config.py_version:
+                self._dunder_methods.extend(extra_dunder_methods)
         for since_vers, dunder_methods in DUNDER_METHODS.items():
             if since_vers <= self.linter.config.py_version:
                 self._dunder_methods.extend(list(dunder_methods.keys()))