Skip to content

Combine Marginalized and Latent Gaussian Mixture Notebooks? #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardoV94 opened this issue Feb 1, 2021 · 3 comments
Open

Combine Marginalized and Latent Gaussian Mixture Notebooks? #32

ricardoV94 opened this issue Feb 1, 2021 · 3 comments

Comments

@ricardoV94
Copy link
Member

The two notebooks are covering exactly the same issue.

They seem short enough that we could use the same dataset and show one after the other. This way we also get a chance to nudge users to try the marginalized mixture, which usually works better.

https://docs.pymc.io/notebooks/gaussian_mixture_model.html
https://docs.pymc.io/notebooks/marginalized_gaussian_mixture_model.html

@OriolAbril
Copy link
Member

@chiral-carbon I don't know enough about either notebook to be a good judge of whether they should be merged nor how. I'd say that if you think its doable after going over both notebooks and @ricardoV94 can help go for it, otherwise leave it for another time

@chiral-carbon
Copy link
Collaborator

okay I'll just update both to best practices for now and keep the combining part for later.

@erik-werner
Copy link
Contributor

https://docs.pymc.io/notebooks/gaussian_mixture_model.html has since been updated to use a marginal mixture. I think https://docs.pymc.io/notebooks/marginalized_gaussian_mixture_model.html is therefore basically redundant, and I would propose to delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants