Skip to content

LKJ #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Mar 29, 2021 · 3 comments
Closed

LKJ #53

OriolAbril opened this issue Mar 29, 2021 · 3 comments
Labels
good first issue Good for newcomers tracker id Issues used as trackers in the notebook update project, do not close!

Comments

@OriolAbril
Copy link
Member

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/case_studies/LKJ.ipynb
Reviewers: @AlexAndorra

Context

Known changes needed

Changes listed in this section should all be done at some point in order to get this
notebook to a "Best Practices" state. However, these are probably not enough!
Make sure to thoroughly review the notebook and search for other updates.

ArviZ related

  • Use labeled dims in code cells 12 and 13. Also use .values instead of .data.

Changes for discussion

Changes listed in this section are up for discussion, these are ideas on how to improve
the notebook but may not have a clear implementation, or fix some know issue only partially.

ArviZ related

Notes

Exotic dependencies

None

Computing power

All models run in less than a minute

@OriolAbril OriolAbril added good first issue Good for newcomers tracker id Issues used as trackers in the notebook update project, do not close! labels Mar 29, 2021
@chiral-carbon
Copy link
Collaborator

taking up this issue.

@PrinceAsiedu
Copy link

Working on this one

@twiecki
Copy link
Member

twiecki commented Nov 17, 2023

Looks done.

@twiecki twiecki closed this as completed Nov 17, 2023
@github-project-automation github-project-automation bot moved this from v4 (auto) to Done in Notebook state tracker Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tracker id Issues used as trackers in the notebook update project, do not close!
Projects
Development

No branches or pull requests

4 participants