Skip to content

LinearModel not setting data #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pdb5627 opened this issue Oct 7, 2023 · 0 comments · Fixed by #249
Closed

LinearModel not setting data #248

pdb5627 opened this issue Oct 7, 2023 · 0 comments · Fixed by #249
Labels
bug Something isn't working

Comments

@pdb5627
Copy link
Contributor

pdb5627 commented Oct 7, 2023

When I originally worked on LinearModel, I assumed that fit() would set data after the model was built, so build_model just put in some dummy data. In later refactoring, this assumption turned out not to be true, so LinearModel never set the model data in the fitting process. I will prepare a PR for a test to check the fit of parameters and add setting data to LinearModel.build_model.

@ricardoV94 ricardoV94 added the bug Something isn't working label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants