Skip to content

Filter variables in model_graphviz #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardoV94 opened this issue Nov 17, 2021 · 7 comments
Closed

Filter variables in model_graphviz #5198

ricardoV94 opened this issue Nov 17, 2021 · 7 comments

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented Nov 17, 2021

@lucianopaz suggested that we could could filter variables similar to the var_names keyword in arviz, so that we plot subsets of the model graph. This should be straightforward with some simple Aesara graph manipulation prior to calling the main function in model_graphviz

@michaelosthege
Copy link
Member

Related: An option to drop disconnected pm.Data nodes from the visualization.

@ricardoV94
Copy link
Member Author

Related: An option to drop disconnected pm.Data nodes from the visualization.

I think that could work out of the box with the filtering based on varnames

@danhphan
Copy link
Member

Hi @ricardoV94 and @michaelosthege, I am happy to take this task.

@ricardoV94
Copy link
Member Author

ricardoV94 commented Jan 29, 2022

Thanks @danhphan!

Just a heads up, this one will require a bit of exploration. We know what we want the behavior to be like, but we don't know exactly how to achieve it just yet.

Let us know if you manage to get something working, and if not, what did you try so we can help.

@danhphan
Copy link
Member

Hi, yes sure, I will do some exploration first. This is a good opportunity to learn model_graphviz and arviz as well 😄

@danhphan
Copy link
Member

Hi, as this issue is going to be solved in #5527, I will focus on other tasks then :). Thanks

@michaelosthege
Copy link
Member

Thanks @danhphan for pointing out the duplicate.
I'm going to close this issue in favor of #5527 (because that one is more concrete in its description).

Regarding the who's working on it (cc @danhphan @soma2000-lang), I wrote it in other issues as well: We don't usually take reservations for issues.
IMO Anybody who wants to resolve an issue should just check if there's already a PR about it and if not open a (draft) pull request to get it done. Any (small) issue that doesn't have a corresponding PR yet can be considered up for grabs. Also those where someone might have been assigned a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants