You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
eval() should be aliased to something more intuitive like sample() or draw() where appropriate.
We have been using eval in our examples as a substitute to the old random method. This is just the standard Aesara debug feature that exists for any node, and shouldn't be used for more than that.
We can have a function wrapper that compiles a "proper" aesara function and takes a given number of draws. For analogy with V3 it could be named pm.random, but I like the pm.draw name better.
Adding default updates to RNGs could then more justifiable be done in pymc.aesaraf.compile_pymc which already does this for Simulator variables anyway, and which pm.random/ pm.draw would call. That would be one less thing that Distribution has to be concerned with.
Hi @ricardoV94, I would like to work on this task. Could you please give some more detailed suggestions (like which file should we put the pm.draw function wrapper, and is there a similar wrapper function to follow). Thank you.
Hi @ricardoV94, I would like to work on this task. Could you please give some more detailed suggestions (like which file should we put the pm.draw function wrapper, and is there a similar wrapper function to follow). Thank you.
Thanks for offering. I assigned the issue to you.
Good question about where it should go... sampling.py perhaps? This is basically a striped down version of prior_predictive. @fonnesbeck what do you think?
I am setting up the dev environment with docker and start reading the sample_prior_predictive function in sampling.py and related files. I will let you know if I face any issue :)
We have been using
eval
in our examples as a substitute to the old random method. This is just the standard Aesara debug feature that exists for any node, and shouldn't be used for more than that.We can have a function wrapper that compiles a "proper" aesara function and takes a given number of draws. For analogy with V3 it could be named
pm.random
, but I like thepm.draw
name better.Adding default updates to RNGs could then more justifiable be done in
pymc.aesaraf.compile_pymc
which already does this for Simulator variables anyway, and whichpm.random
/pm.draw
would call. That would be one less thing that Distribution has to be concerned with.pymc/pymc/aesaraf.py
Line 968 in 75ea2a8
Originally posted by @ricardoV94 in #5308 (comment)
The text was updated successfully, but these errors were encountered: