Skip to content

add coords argument to pymc.set_data #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OriolAbril opened this issue Mar 4, 2022 · 4 comments · Fixed by #5588
Closed

add coords argument to pymc.set_data #5547

OriolAbril opened this issue Mar 4, 2022 · 4 comments · Fixed by #5588

Comments

@OriolAbril
Copy link
Member

OriolAbril commented Mar 4, 2022

pymc.set_data is a wrapper around pymc.Model.set_data method that supports setting multiple data variables at the same time and it is currently missing the coords argument. Adding a coord argument to pymc.set_data and passing it to the method when called should already work.

Sources

cc @michaelosthege

@purna135
Copy link
Member

purna135 commented Mar 6, 2022

I would like to work on this.

@OriolAbril
Copy link
Member Author

Hi @purna135, sorry for the late reply. @soma2000-lang has already submitted a PR so you should not work on this issue to avoid duplicated work.

@soma2000-lang (to be read after #5588 (review)). I know finding issues to contribute when getting started with a new library is tricky, I personally struggled with it when I started and I still struggle sometimes when trying to contribute to new libraries, even after years being a maintainer of PyMC and ArviZ. However, you should still find an issue, comment there that you are planning to work on it (or simply start with "I am interested but the issue is not clear" before saying you'll work on that) and then submit the pull request. We are many people working and contributing to pymc, and we do not want to work double. If you send PRs for issues that have been assigned to someone else it is probable that we'll end up with two PRs that fix the same issue and would be forced to reject one of them. We don't want to reject PRs not want any contributor to work on changes that are eventually discarded and following this process is the way we have to make sure we don't have to discard anyone's work.

I would also like to highlight the upcoming office hours, that both of you can attend and ask any and all questions related to contributing to PyMC and GSoC, there will be some of the potential GSoC mentors and participants from previous rounds attending. See https://discourse.pymc.io/t/pymc-office-hours/9018.

I am really happy to see people interested in PyMC and I hope everyone can find issues to work on and can submit a proposal and be accepted for GSoC. Which is also partially why I dedicate a lot of my time to documentation efforts hoping to make using and contributing to PyMC more and more clear every day, but like with the rest of the developers, I do that on my free time so my availability is not constant or even regular and the ammount of work and reviews I can do is limited so I often answer late or are forced to answer in very short comments that might not be very clear.

@purna135
Copy link
Member

purna135 commented Mar 15, 2022

Hi @purna135, sorry for the late reply. @soma2000-lang has already submitted a PR so you should not work on this issue to avoid duplicated work.

@OriolAbril Thank you for your response; I'm currently working on other issues.

@soma2000-lang
Copy link
Contributor

Hi @purna135, sorry for the late reply. @soma2000-lang has already submitted a PR so you should not work on this issue to avoid duplicated work.

@soma2000-lang (to be read after #5588 (review)). I know finding issues to contribute when getting started with a new library is tricky, I personally struggled with it when I started and I still struggle sometimes when trying to contribute to new libraries, even after years being a maintainer of PyMC and ArviZ. However, you should still find an issue, comment there that you are planning to work on it (or simply start with "I am interested but the issue is not clear" before saying you'll work on that) and then submit the pull request. We are many people working and contributing to pymc, and we do not want to work double. If you send PRs for issues that have been assigned to someone else it is probable that we'll end up with two PRs that fix the same issue and would be forced to reject one of them. We don't want to reject PRs not want any contributor to work on changes that are eventually discarded and following this process is the way we have to make sure we don't have to discard anyone's work.

I would also like to highlight the upcoming office hours, that both of you can attend and ask any and all questions related to contributing to PyMC and GSoC, there will be some of the potential GSoC mentors and participants from previous rounds attending. See https://discourse.pymc.io/t/pymc-office-hours/9018.

I am really happy to see people interested in PyMC and I hope everyone can find issues to work on and can submit a proposal and be accepted for GSoC. Which is also partially why I dedicate a lot of my time to documentation efforts hoping to make using and contributing to PyMC more and more clear every day, but like with the rest of the developers, I do that on my free time so my availability is not constant or even regular and the ammount of work and reviews I can do is limited so I often answer late or are forced to answer in very short comments that might not be very clear.

@OriolAbril I would definitely attend the meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants