-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ENH: Improve debug docs and function helpers #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It seems like the notebook is doing its job? I don't think we should add a Instead I would propose to:
def print_value(var, name=None):
"""Print value of variable when it is computed during sampling.
This is likely to affect sampling performance.
"""
if name is None:
name = var.name
return Print(name)(var)
|
@ricardoV94 I like all these suggestions. |
I would like to work on this issue. |
Great @itsdivya1309, do you have any questions on how to get going? Otherwise, feel free to open draft PR and we can take it from there. |
Correct me if I am wrong, but I need to update this notebook as suggested above, right? |
@itsdivya1309 Correct. |
I don't understand what you mean by 'Implement PrintOp in JAX'. Can you please explain. |
@itsdivya1309 You can treat that as a separate issue. As you can see in the NB, we're using But you can just do the changes to the NB for now. |
Alright |
@twiecki, I am also interested in this issue and it is not assigned to anyone. Can I open a Pr since no pr is opened? |
My understanding of the issue:-
|
@AryanNanda17 you can work on the JAX part if you want. |
Before
After
Context for the issue:
On https://www.pymc.io/projects/examples/en/latest/howto/howto_debugging.html we show how
pytensor.printing.Print
can be used to debug-print RVs which is helpful for debugging model issues. This could be done with nicer API if we add adebug
kwarg that would wrap the RV internally with aPrint
Op.The text was updated successfully, but these errors were encountered: