Skip to content

Clarify dims error message to reference as_xtensor#8066

Merged
ricardoV94 merged 2 commits intopymc-devs:mainfrom
AdishreeB:dims-error-message-clarification
Jan 26, 2026
Merged

Clarify dims error message to reference as_xtensor#8066
ricardoV94 merged 2 commits intopymc-devs:mainfrom
AdishreeB:dims-error-message-clarification

Conversation

@AdishreeB
Copy link
Copy Markdown
Contributor

Description

This PR clarifies an error message raised when variables are missing associated dims.
The message now explicitly references pytensor.xtensor.as_xtensor(..., dims=...),
making it clearer how users should attach dims to observed data and reducing
confusion about where as_xtensor is defined.

No behaviour changes are introduced; this PR only improves a user-facing error message

Related Issue

Checklist

  • Checked that the pre-commit linting/style checks pass
  • Included tests that prove the fix is effective or that the new feature works
  • Added necessary documentation (docstrings and/or example notebooks)
  • If you are a pro: each commit corresponds to a relevant logical change

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.80%. Comparing base (a375fd1) to head (374aaaa).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8066      +/-   ##
==========================================
+ Coverage   88.76%   90.80%   +2.03%     
==========================================
  Files         116      121       +5     
  Lines       18971    19426     +455     
==========================================
+ Hits        16840    17639     +799     
+ Misses       2131     1787     -344     
Files with missing lines Coverage Δ
pymc/dims/distributions/core.py 89.55% <ø> (ø)

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricardoV94 ricardoV94 merged commit 91825eb into pymc-devs:main Jan 26, 2026
42 checks passed
@welcome
Copy link
Copy Markdown

welcome bot commented Jan 26, 2026

Congratulations Banner]
Congrats on merging your first pull request! 🎉 We here at PyMC are proud of you! 💖 Thank you so much for your contribution 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants