Support xtensor inputs in check_parameters - #8399
Open
ishitta-iyer wants to merge 1 commit into
Open
Conversation
ishitta-iyer
force-pushed
the
bugfix/check-parameters-xtensor
branch
from
August 14, 2026 23:58
b0f5e49 to
166a7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend pymc.distributions.dist_math.check_parameters to fully support XTensorVariable expressions and conditions.
XTensor conditions are lowered before reduction with pt.all, avoiding PyTensor’s forbidden implicit XTensor-to-tensor conversion. XTensor expressions are lowered before applying CheckParameterValue, then converted back with their original dims. This also allows PyMC’s CheckParameterValue-to--inf compilation rewrite to operate correctly.
Ordinary tensor behavior remains unchanged, including mixed tensor/XTensor conditions. Focused regression tests cover valid and invalid conditions, compiled -inf replacement, return types, preserved dims, dtype and shape, mixed conditions, and Python boolean conditions.
Related Issue
Checklist
Type of change