Raise warnings when test_val is accessed

Added pytest Future Warning in relavant tests

Removed and replaced usage of test_value in JAX/Numba tests

Author: Dhruvanshu-Joshi

pytensor/compile/sharedvalue.py

@@ -1,6 +1,7 @@
 """Provide a simple user friendly API to PyTensor-managed memory."""
 
 import copy
+import warnings
 from contextlib import contextmanager
 from functools import singledispatch
 from typing import TYPE_CHECKING
@@ -134,6 +135,10 @@ def set_value(self, new_value, borrow=False):
             self.container.value = copy.deepcopy(new_value)
 
     def get_test_value(self):
+        warnings.warn(
+            "test_value machinery is deprecated and will stop working in the future.",
+            FutureWarning,
+        )
         return self.get_value(borrow=True, return_internal_type=True)
 
     def clone(self, **kwargs):

pytensor/configdefaults.py

@@ -6,6 +6,7 @@
 import socket
 import sys
 import textwrap
+import warnings
 
 import numpy as np
 from setuptools._distutils.spawn import find_executable
@@ -1447,6 +1448,12 @@ def add_caching_dir_configvars():
 else:
     gcc_version_str = "GCC_NOT_FOUND"
 
+if config.compute_test_value != "off":
+    warnings.warn(
+        "test_value machinery is deprecated and will stop working in the future.",
+        FutureWarning,
+    )
+
 # TODO: The caching dir resolution is a procedural mess of helper functions, local variables
 # and config definitions. And the result is also not particularly pretty..
 add_caching_dir_configvars()

pytensor/graph/basic.py

@@ -784,6 +784,10 @@ def __init__(self, type: _TypeType, data: Any, name: str | None = None):
         add_tag_trace(self)
 
     def get_test_value(self):
+        warnings.warn(
+            "test_value machinery is deprecated and will stop working in the future.",
+            FutureWarning,
+        )
         return self.data
 
     def signature(self):

pytensor/graph/op.py

@@ -708,6 +708,11 @@ def get_test_values(*args: Variable) -> Any | list[Any]:
 
     """
 
+    warnings.warn(
+        "test_value machinery is deprecated and will stop working in the future.",
+        FutureWarning,
+    )
+
     if config.compute_test_value == "off":
         return []
 

pytensor/graph/utils.py

@@ -1,6 +1,7 @@
 import linecache
 import sys
 import traceback
+import warnings
 from abc import ABCMeta
 from collections.abc import Sequence
 from io import StringIO
@@ -283,9 +284,19 @@ def info(self):
 
     # These two methods have been added to help Mypy
     def __getattribute__(self, name):
+        if name == "test_value":
+            warnings.warn(
+                "test_value machinery is deprecated and will stop working in the future.",
+                FutureWarning,
+            )
         return super().__getattribute__(name)
 
     def __setattr__(self, name: str, value: Any) -> None:
+        if name == "test_value":
+            warnings.warn(
+                "test_value machinery is deprecated and will stop working in the future.",
+                FutureWarning,
+            )
         self.__dict__[name] = value
 
 
@@ -300,6 +311,11 @@ def __init__(self, attr, attr_filter):
 
     def __setattr__(self, attr, obj):
         if getattr(self, "attr", None) == attr:
+            if attr == "test_value":
+                warnings.warn(
+                    "test_value machinery is deprecated and will stop working in the future.",
+                    FutureWarning,
+                )
             obj = self.attr_filter(obj)
 
         return object.__setattr__(self, attr, obj)

tests/compile/test_builders.py

@@ -523,11 +523,12 @@ def test_infer_shape(self):
 
     @config.change_flags(compute_test_value="raise")
     def test_compute_test_value(self):
-        x = scalar("x")
-        x.tag.test_value = np.array(1.0, dtype=config.floatX)
-        op = OpFromGraph([x], [x**3])
-        y = scalar("y")
-        y.tag.test_value = np.array(1.0, dtype=config.floatX)
+        with pytest.warns(FutureWarning):
+            x = scalar("x")
+            x.tag.test_value = np.array(1.0, dtype=config.floatX)
+            op = OpFromGraph([x], [x**3])
+            y = scalar("y")
+            y.tag.test_value = np.array(1.0, dtype=config.floatX)
         f = op(y)
         grad_f = grad(f, y)
         assert grad_f.tag.test_value is not None

tests/compile/test_ops.py

@@ -33,9 +33,7 @@ def cumprod(x):
 
     def test_2arg(self):
         x = dmatrix("x")
-        x.tag.test_value = np.zeros((2, 2))
         y = dvector("y")
-        y.tag.test_value = [0, 0, 0, 0]
 
         @as_op([dmatrix, dvector], dvector)
         def cumprod_plus(x, y):
@@ -49,9 +47,7 @@ def cumprod_plus(x, y):
 
     def test_infer_shape(self):
         x = dmatrix("x")
-        x.tag.test_value = np.zeros((2, 2))
         y = dvector("y")
-        y.tag.test_value = [0, 0, 0, 0]
 
         def infer_shape(fgraph, node, shapes):
             x, y = shapes

tests/graph/test_basic.py

@@ -371,14 +371,15 @@ def test_eval_kwargs(self):
     def test_eval_unashable_kwargs(self):
         y_repl = constant(2.0, dtype="floatX")
 
-        assert self.w.eval({self.x: 1.0}, givens=((self.y, y_repl),)) == 6.0
-
-        with pytest.warns(
-            UserWarning,
-            match="Keyword arguments could not be used to create a cache key",
-        ):
-            # givens dict is not hashable
-            assert self.w.eval({self.x: 1.0}, givens={self.y: y_repl}) == 6.0
+        with pytest.warns(FutureWarning):
+            assert self.w.eval({self.x: 1.0}, givens=((self.y, y_repl),)) == 6.0
+
+            with pytest.warns(
+                UserWarning,
+                match="Keyword arguments could not be used to create a cache key",
+            ):
+                # givens dict is not hashable
+                assert self.w.eval({self.x: 1.0}, givens={self.y: y_repl}) == 6.0
 
 
 class TestAutoName:

tests/graph/test_compute_test_value.py

@@ -67,7 +67,8 @@ def perform(self, node, inputs, outputs):
 
         test_input = SomeType()()
         orig_object = object()
-        test_input.tag.test_value = orig_object
+        with pytest.warns(FutureWarning):
+            test_input.tag.test_value = orig_object
 
         res = InplaceOp(False)(test_input)
         assert res.tag.test_value is orig_object
@@ -76,10 +77,11 @@ def perform(self, node, inputs, outputs):
         assert res.tag.test_value is not orig_object
 
     def test_variable_only(self):
-        x = matrix("x")
-        x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
-        y = matrix("y")
-        y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            x = matrix("x")
+            x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
+            y = matrix("y")
+            y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
 
         # should work
         z = dot(x, y)
@@ -88,14 +90,16 @@ def test_variable_only(self):
         assert _allclose(f(x.tag.test_value, y.tag.test_value), z.tag.test_value)
 
         # this test should fail
-        y.tag.test_value = np.random.random((6, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            y.tag.test_value = np.random.random((6, 5)).astype(config.floatX)
         with pytest.raises(ValueError):
             dot(x, y)
 
     def test_compute_flag(self):
         x = matrix("x")
         y = matrix("y")
-        y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
 
         # should skip computation of test value
         with config.change_flags(compute_test_value="off"):
@@ -111,10 +115,11 @@ def test_compute_flag(self):
             dot(x, y)
 
     def test_string_var(self):
-        x = matrix("x")
-        x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
-        y = matrix("y")
-        y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            x = matrix("x")
+            x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
+            y = matrix("y")
+            y.tag.test_value = np.random.random((4, 5)).astype(config.floatX)
 
         z = pytensor.shared(np.random.random((5, 6)).astype(config.floatX))
 
@@ -134,7 +139,8 @@ def f(x, y, z):
 
     def test_shared(self):
         x = matrix("x")
-        x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            x.tag.test_value = np.random.random((3, 4)).astype(config.floatX)
         y = pytensor.shared(np.random.random((4, 6)).astype(config.floatX), "y")
 
         # should work
@@ -190,30 +196,31 @@ def test_constant(self):
     def test_incorrect_type(self):
         x = vector("x")
         with pytest.raises(TypeError):
-            # Incorrect shape for test value
-            x.tag.test_value = np.empty((2, 2))
+            with pytest.warns(FutureWarning):
+                # Incorrect shape for test value
+                x.tag.test_value = np.empty((2, 2))
 
         x = fmatrix("x")
         with pytest.raises(TypeError):
-            # Incorrect dtype (float64) for test value
-            x.tag.test_value = np.random.random((3, 4))
+            with pytest.warns(FutureWarning):
+                # Incorrect dtype (float64) for test value
+                x.tag.test_value = np.random.random((3, 4))
 
     def test_overided_function(self):
         # We need to test those as they mess with Exception
         # And we don't want the exception to be changed.
         x = matrix()
-        x.tag.test_value = np.zeros((2, 3), dtype=config.floatX)
         y = matrix()
-        y.tag.test_value = np.zeros((2, 2), dtype=config.floatX)
         with pytest.raises(ValueError):
             x.__mul__(y)
 
     def test_scan(self):
         # Test the compute_test_value mechanism Scan.
         k = iscalar("k")
         A = vector("A")
-        k.tag.test_value = 3
-        A.tag.test_value = np.random.random((5,)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            k.tag.test_value = 3
+            A.tag.test_value = np.random.random((5,)).astype(config.floatX)
 
         def fx(prior_result, A):
             return prior_result * A
@@ -233,8 +240,9 @@ def test_scan_err1(self):
         # This test should fail when building fx for the first time
         k = iscalar("k")
         A = matrix("A")
-        k.tag.test_value = 3
-        A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            k.tag.test_value = 3
+            A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
 
         def fx(prior_result, A):
             return dot(prior_result, A)
@@ -253,8 +261,9 @@ def test_scan_err2(self):
         # but when calling the scan's perform()
         k = iscalar("k")
         A = matrix("A")
-        k.tag.test_value = 3
-        A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
+        with pytest.warns(FutureWarning):
+            k.tag.test_value = 3
+            A.tag.test_value = np.random.random((5, 3)).astype(config.floatX)
 
         def fx(prior_result, A):
             return dot(prior_result, A)
@@ -288,7 +297,8 @@ def perform(self, node, inputs, outputs):
                 output[0] = input + 1
 
         i = ps.int32("i")
-        i.tag.test_value = 3
+        with pytest.warns(FutureWarning):
+            i.tag.test_value = 3
 
         o = IncOnePython()(i)
 
@@ -304,7 +314,8 @@ def perform(self, node, inputs, outputs):
     )
     def test_no_perform(self):
         i = ps.int32("i")
-        i.tag.test_value = 3
+        with pytest.warns(FutureWarning):
+            i.tag.test_value = 3
 
         # Class IncOneC is defined outside of the TestComputeTestValue
         # so it can be pickled and unpickled

tests/graph/test_fg.py

@@ -233,18 +233,19 @@ def test_change_input(self):
 
     @config.change_flags(compute_test_value="raise")
     def test_replace_test_value(self):
-        var1 = MyVariable("var1")
-        var1.tag.test_value = 1
-        var2 = MyVariable("var2")
-        var2.tag.test_value = 2
-        var3 = op1(var2, var1)
-        var4 = op2(var3, var2)
-        var4.tag.test_value = np.array([1, 2])
-        var5 = op3(var4, var2, var2)
-        fg = FunctionGraph([var1, var2], [var3, var5], clone=False)
-
-        var6 = op3()
-        var6.tag.test_value = np.array(0)
+        with pytest.warns(FutureWarning):
+            var1 = MyVariable("var1")
+            var1.tag.test_value = 1
+            var2 = MyVariable("var2")
+            var2.tag.test_value = 2
+            var3 = op1(var2, var1)
+            var4 = op2(var3, var2)
+            var4.tag.test_value = np.array([1, 2])
+            var5 = op3(var4, var2, var2)
+            fg = FunctionGraph([var1, var2], [var3, var5], clone=False)
+
+            var6 = op3()
+            var6.tag.test_value = np.array(0)
 
         assert var6.tag.test_value.shape != var4.tag.test_value.shape