Skip to content

Efficient Conv Ops were removed accidentally #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ricardoV94 opened this issue May 17, 2023 · 1 comment · May be fixed by #548
Open

Efficient Conv Ops were removed accidentally #305

ricardoV94 opened this issue May 17, 2023 · 1 comment · May be fixed by #548
Labels
C-backend help wanted Extra attention is needed performance

Comments

@ricardoV94
Copy link
Member

ricardoV94 commented May 17, 2023 •
edited
Loading

Description

We removed the deprecated nnet module in #111

But we wanted to keep the Convolution Ops. Unfortunately we keept only the "abstract" ones, and not the fast variations implemented in conv.py. We should bring them back, including the rewrites that replace abstract forms by the equivalent fast ones.

https://discourse.pymc.io/t/very-slow-2d-convolution-with-pytensor/12118/6
@jessegrabowski
Copy link
Member

Also related to #275 I think

@lmmx lmmx mentioned this issue Dec 7, 2023
Closed
@jessegrabowski jessegrabowski linked a pull request Dec 11, 2023 that will close this issue
Draft
12 tasks
@jessegrabowski jessegrabowski mentioned this issue Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-backend help wanted Extra attention is needed performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore fast convolution Ops, rewrites, and docs jessegrabowski/pytensor
2 participants
@ricardoV94 @jessegrabowski