Skip to content

Remove reimplementation of np.testing.assert_allclose #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ricardoV94 opened this issue Dec 13, 2023 · 2 comments · May be fixed by #562 or #784
Open

Remove reimplementation of np.testing.assert_allclose #551

ricardoV94 opened this issue Dec 13, 2023 · 2 comments · May be fixed by #562 or #784
Labels
beginner friendly maintenance tests

Comments

@ricardoV94
Copy link
Member

pytensor/tests/unittest_tools.py

Lines 280 to 282 in 9df55cc

def assert_allclose(expected, value, rtol=None, atol=None):
if not _allclose(expected, value, rtol, atol):
raise WrongValue(expected, value, rtol, atol)

@ricardoV94 ricardoV94 changed the title Do not reinvent np.testing.asselt_allclose Do not reinvent np.testing.assert_allclose Dec 13, 2023
@ricardoV94 ricardoV94 changed the title Do not reinvent np.testing.assert_allclose Remove reimplementation of np.testing.assert_allclose Dec 13, 2023
@jaharvey8
Copy link

Just need to delete this function in unittest_tools and then change any remaining instances of utt.assert_allclose to np.testing.assert_allclose correct?

@ricardoV94
Copy link
Member Author

yup

@jaharvey8 jaharvey8 linked a pull request Dec 19, 2023 that will close this issue
Open
10 tasks
@Dhruvanshu-Joshi Dhruvanshu-Joshi linked a pull request May 27, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly maintenance tests
Projects
None yet
Milestone
No milestone
2 participants
@jaharvey8 @ricardoV94