fix: test_dependency_constraints_file when using build

Author: mayeut

cibuildwheel/macos.py

@@ -19,6 +19,7 @@
     NonPlatformWheelError,
     download,
     get_build_verbosity_extra_flags,
+    get_pip_version,
     install_certifi_script,
     prepare_command,
     read_python_configs,
@@ -319,7 +320,7 @@ def setup_python(
                 "install",
                 "--upgrade",
                 "delocate",
-                "build",
+                "build[virtualenv]",
                 *dependency_constraint_flags,
             ],
             env=env,
@@ -396,6 +397,12 @@ def build(options: BuildOptions) -> None:
 
             if options.pypa_build:
                 config_setting = " ".join(verbosity_flags)
+                build_env = dict(env)
+                if options.dependency_constraints:
+                    build_env["PIP_CONSTRAINT"] = str(
+                        options.dependency_constraints.get_for_python_version(config.version)
+                    )
+                build_env["VIRTUALENV_PIP"] = get_pip_version(env)
                 call(
                     [
                         "python",
@@ -406,7 +413,7 @@ def build(options: BuildOptions) -> None:
                         f"--outdir={built_wheel_dir}",
                         f"--config-setting={config_setting}",
                     ],
-                    env=env,
+                    env=build_env,
                 )
             else:
                 # Path.resolve() is needed. Without it pip wheel may try to fetch package from pypi.org

cibuildwheel/util.py

@@ -4,6 +4,8 @@
 import os
 import re
 import ssl
+import subprocess
+import sys
 import textwrap
 import time
 import urllib.request
@@ -275,3 +277,18 @@ def print_new_wheels(msg: str, output_dir: Path) -> Iterator[None]:
     s = time.time() - start_time
     m = s / 60
     print(msg.format(n=n, s=s, m=m), *sorted(f"  {f.name}" for f in new_contents), sep="\n")
+
+
+def get_pip_version(env: Dict[str, str]) -> str:
+    # we use shell=True here for windows, even though we don't need a shell due to a bug
+    # https://bugs.python.org/issue8557
+    shell = sys.platform.startswith("win")
+    versions_output_text = subprocess.check_output(
+        ["python", "-m", "pip", "freeze", "--all"], universal_newlines=True, shell=shell, env=env
+    )
+    (pip_version,) = [
+        version[5:]
+        for version in versions_output_text.strip().splitlines()
+        if version.startswith("pip==")
+    ]
+    return pip_version

cibuildwheel/windows.py

@@ -17,6 +17,7 @@
     NonPlatformWheelError,
     download,
     get_build_verbosity_extra_flags,
+    get_pip_version,
     prepare_command,
     read_python_configs,
 )
@@ -291,6 +292,12 @@ def build(options: BuildOptions) -> None:
 
             if options.pypa_build:
                 config_setting = " ".join(verbosity_flags)
+                build_env = dict(env)
+                if options.dependency_constraints:
+                    build_env["PIP_CONSTRAINT"] = str(
+                        options.dependency_constraints.get_for_python_version(config.version)
+                    )
+                build_env["VIRTUALENV_PIP"] = get_pip_version(env)
                 call(
                     [
                         "python",
@@ -301,7 +308,7 @@ def build(options: BuildOptions) -> None:
                         f"--outdir={built_wheel_dir}",
                         f"--config-setting={config_setting}",
                     ],
-                    env=env,
+                    env=build_env,
                 )
             else:
                 # Path.resolve() is needed. Without it pip wheel may try to fetch package from pypi.org

test/test_dependency_versions.py

@@ -118,7 +118,7 @@ def test_dependency_constraints_file(tmp_path):
         "pip": "20.0.2",
         "setuptools": "53.0.0",
         "wheel": "0.34.2",
-        "virtualenv": "20.0.10",
+        "virtualenv": "20.0.35",
     }
 
     constraints_file = tmp_path / "constraints.txt"
@@ -129,6 +129,7 @@ def test_dependency_constraints_file(tmp_path):
             setuptools=={setuptools}
             wheel=={wheel}
             virtualenv=={virtualenv}
+            importlib-metadata<3,>=0.12; python_version < "3.8"
             """.format(
                 **tool_versions
             )